Skip to content

Allow package IDs to refer to the middle of a source repository #6408

Closed

Description

@catamorphism

Sub-bug of #5677

Currently, rustpkg assumes that a remote package ID refers to the root level of a particular source repository. @brson suggested that to obviate the need for servo to use git submodules, we could allow package IDs to point into a subdirectory of a repo. It's unclear whether we should implement this. See discussion at https://etherpad.mozilla.org/Rustpkg-Servo-meeting

Activity

  1. emberian commented on Jul 23, 2013

    @emberian
    Contributor

    This seems like a good idea to me. Imagine a C library that ships rust bindings in a 'rust' subdirectory.

  2. lilyball commented on Aug 23, 2013

    @lilyball
    Contributor

    Go allows you to reference a sub-path of a repo. It checks out the correct repo, and only builds that sub-path.

  3. lilyball commented on Aug 23, 2013

    @lilyball
    Contributor

    If this is implemented (and I think it should be), then rustpkg should also stop recursively searching for lib.rs (and the other magic files) and instead require them to be in the root. This is because rustpkg assumes that the last path component of the pkgid is the name of the library, and it would be very confusing if I could type both rustpkg install github.com/foo/bar and rustpkg install github.com/foo/bar/baz and have both build the same library, but only the latter successfully install.

  4. added a commit that references this issue on Sep 12, 2013
    3226a80
  5. added a commit that references this issue on Sep 12, 2013
    761ae00
  6. removed their assignment
    on Jun 16, 2014
  7. added a commit that references this issue on Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions