Skip to content

decl macro 2.0 doesn't allow trailing comma #63102

Closed
#63198
Closed
decl macro 2.0 doesn't allow trailing comma#63102
#63198
Labels
A-decl-macros-2-0Area: Declarative macros 2.0 (#39412)A-parserArea: The lexing & parsing of Rust source code to an ASTC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@bjorn3
bjorn3
opened on Jul 29, 2019
macro abc {
    () => {},

(Playground)

Errors:

   Compiling playground v0.0.1 (/playground)
error: unexpected end of macro invocation
 --> src/lib.rs:2:14
  |
2 |     () => {},
  |              ^ missing tokens in macro arguments

error: aborting due to previous error

error: Could not compile `playground`.

To learn more, run the command again with --verbose.

Activity

  1. jonas-schievink
    added
    A-decl-macros-2-0Area: Declarative macros 2.0 (#39412)
    A-parserArea: The lexing & parsing of Rust source code to an AST
    C-bugCategory: This is a bug.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jul 29, 2019

  2. matthewjasper commented on Jul 29, 2019

    @matthewjasper
    matthewjasper
    on Jul 29, 2019
    Contributor

    But they do accept a trailing ;: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=f8bd2841ec49d0222be9ad6124bdd0a4

  3. bjorn3 commented on Jul 29, 2019

    @bjorn3
    bjorn3
    on Jul 29, 2019
    MemberAuthor

    Maybe someone forgot to change the trailing ; into , when changing the separating ; into , in the (copied?) parse code?

  4. Centril
    added a commit that references this issue on Aug 2, 2019

    Rollup merge of rust-lang#63198 - rbartlensky:fix-macro-trailing-comm…

    89dce46
  5. bors
    closed this as completedin #63198on Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-decl-macros-2-0Area: Declarative macros 2.0 (#39412)A-parserArea: The lexing & parsing of Rust source code to an ASTC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions