Skip to content

Code under the 2-clause-BSD license is not documented as a compatible license for the Rust runtime #62620

Closed

Description

@gnzlbg

The 2-clause-BSD license is not documented in the tidy script as being a compatible license for the rust runtime dependencies. We used to ship BSD licensed code as part of libstd until recently: 0b85b64#diff-4131508972c86fdd799a5f7d41fdd323 and we shipped jemalloc for a long time as part of the runtime on many targets.

We still do ship code with the MPL2.0 license in some targets, see: https://github.com/rust-lang/rust/blob/master/src/tools/tidy/src/deps.rs#L51

The deps check of the tidy script should be better documented to explain what's allowed and what isn't.

Activity

  1. added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    C-bugCategory: This is a bug.
    on Jul 12, 2019
  2. Mark-Simulacrum commented on Jul 17, 2019

    @Mark-Simulacrum
    Member

    We discussed this a bit today and concluded that we don't need the SGX dependencies to be appropriately licensed (they're somewhat "third party") so I'm closing this issue.

  3. gnzlbg commented on Jul 17, 2019

    @gnzlbg
    ContributorAuthor

    So does that mean that it is ok to add third party libraries to the runtime under this license?

    If so the documentation comment in the tidy script should be updated.

  4. Mark-Simulacrum commented on Jul 17, 2019

    @Mark-Simulacrum
    Member

    Not in general. In this case, it's specifically for SGX so that's why we're not concerned about it.

  5. gnzlbg commented on Jul 17, 2019

    @gnzlbg
    ContributorAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions