Deduplicate error messages

@RalfJung

Lines 557 to 568 in 3977cc2

    
                   let err = error_to_const_error(&ecx, error); 
        
                   match err.struct_error(ecx.tcx, "it is undefined behavior to use this value") { 
        
                       Ok(mut diag) => { 
        
                           diag.note("The rules on what exactly is undefined behavior aren't clear, \ 
        
                               so this check might be overzealous. Please open an issue on the rust compiler \ 
        
                               repository if you believe it should not be considered undefined behavior", 
        
                           ); 
        
                           diag.emit(); 
        
                           ErrorHandled::Reported 
        
                       } 
        
                       Err(err) => err, 
        
                   }

and

rust/src/librustc_mir/interpret/intern.rs

Lines 293 to 305 in 3977cc2

    
                           let err = crate::const_eval::error_to_const_error(&ecx, error); 
        
                           match err.struct_error(ecx.tcx, "it is undefined behavior to use this value") { 
        
                               Ok(mut diag) => { 
        
                                   diag.note("The rules on what exactly is undefined behavior aren't clear, \ 
        
                                       so this check might be overzealous. Please open an issue on the rust \ 
        
                                       compiler repository if you believe it should not be considered \ 
        
                                       undefined behavior", 
        
                                   ); 
        
                                   diag.emit(); 
        
                               } 
        
                               Err(ErrorHandled::TooGeneric) | 
        
                               Err(ErrorHandled::Reported) => {}, 
        
                           }

could be deduplicated by creating a function in const_eval.rs and calling it from both sites

This issue has been assigned to @chansuke via this comment.

I'd like to work on this issue.

Great! It's all yours.

@rustbot

@rustbot claim

@chansuke

@chansuke Are you still working on this? If not I can pick it up :)

Rollup merge of rust-lang#62760 - chansuke:dedupe-error-messages, r=z…

This was closed in #62760

Navigation Menu

Repository navigation

Deduplicate error messages #62022

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	let err = error_to_const_error(&ecx, error);
	match err.struct_error(ecx.tcx, "it is undefined behavior to use this value") {
	Ok(mut diag) => {
	diag.note("The rules on what exactly is undefined behavior aren't clear, \
	so this check might be overzealous. Please open an issue on the rust compiler \
	repository if you believe it should not be considered undefined behavior",
	);
	diag.emit();
	ErrorHandled::Reported
	}
	Err(err) => err,
	}

	let err = crate::const_eval::error_to_const_error(&ecx, error);
	match err.struct_error(ecx.tcx, "it is undefined behavior to use this value") {
	Ok(mut diag) => {
	diag.note("The rules on what exactly is undefined behavior aren't clear, \
	so this check might be overzealous. Please open an issue on the rust \
	compiler repository if you believe it should not be considered \
	undefined behavior",
	);
	diag.emit();
	}
	Err(ErrorHandled::TooGeneric) \|
	Err(ErrorHandled::Reported) => {},
	}

Deduplicate error messages #62022

Description

Activity

chansuke commented on Jun 21, 2019

oli-obk commented on Jun 21, 2019

chansuke commented on Jun 23, 2019

saleemjaffer commented on Jul 10, 2019

wesleywiser commented on Aug 16, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions