Skip to content

Get rid of the test-miri flag in config.toml #61833

Closed

Description

@oli-obk

The test-miri flag changes whether -Zalways-encode-mir is passed to rustc, causing all metadata beyond stage 0 to include MIR of all functions, even private monomorphic ones. Instead, what we can do is to have miri tests first run cargo miri setup to generate that special libstd in CI in addition to the regular libstd. Then tests can be run with special libstd.

cc @RalfJung

Activity

  1. added
    T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.
    A-miriArea: The miri tool
    on Jun 14, 2019
  2. RalfJung commented on Jun 14, 2019

    @RalfJung
    Member

    Worse, it also passes --cfg miri to rustc, meaning we get the hashbrown without SIMD!

  3. RalfJung commented on Jun 14, 2019

    @RalfJung
    Member

    Oh also, ideally this could use or at least share some code with the build script Miri uses to do the same on its own CI.

    EDIT: Or maybe not, that does some crazy RUSTFLAGS stuff that probably should not be done for the released artifact.

  4. RalfJung commented on Jul 31, 2019

    @RalfJung
    Member

    I submitted a PR for this at #63162.

  5. added a commit that references this issue on Aug 8, 2019
  6. added a commit that references this issue on Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-miriArea: The miri toolT-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions