Improve E0599 for missing trait bounds (where clauses)

@estebank

For the following example:

struct Foo<T> {
    t: T,
}

struct Inner {
    i: u8,
}

trait Bar {
    fn bar(&self);
}

impl<T> Bar for Foo<T> where T: Clone {
    fn bar(&self) {
        println!("x");
    }
}

fn main() {
    let foo = Foo { t: Inner { i: b'i' } };
    foo.bar();
}

The error message is:

error[E0599]: no method named `bar` found for type `Foo<Inner>` in the current scope
  --> src/main.rs:21:9
   |
1  | struct Foo<T> {
   | ------------- method `bar` not found for this
...
21 |     foo.bar();
   |         ^^^
   |
   = note: the method `bar` exists but the following trait bounds were not satisfied:
           `Foo<Inner> : Bar`
   = help: items from traits can only be used if the trait is implemented and in scope
   = note: the following trait defines an item `bar`, perhaps you need to implement it:
           candidate #1: `Bar`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
error: Could not compile `playground`.

To learn more, run the command again with --verbose.

Foo<T> does actually implement Bar, and this makes the suggestions from the compiler misleading in this case: there is already an implementation for Foo<T> : Bar, and Bar is already in scope. It would be much more helpful if the compiler could suggest the trait bounds necessary to satisfy the requirement.

This seems very similar to what @estebank suggested in #9082 (comment).

Would the following be enough of an improvement?

error[E0599]: no method named `bar` found for struct `Foo<Inner>` in the current scope
   --> file5.rs:21:9
    |
1   |   struct Foo<T> {
    |   ------------- method `bar` not found for this
...
21  |       foo.bar();
    |           ^^^ method not found in `Foo<Inner>`
    |
    = note: the method `bar` exists but the following trait bounds were not satisfied:
            `Inner: std::clone::Clone` which is required by `Foo<Inner>: Bar`
    = help: items from traits can only be used if the trait is implemented and in scope
    = note: the following trait defines an item `bar`, perhaps you need to implement it:
            candidate #1: `Bar`

This is a great improvement! In this context, the latter three lines are somewhat confusing:

    = help: items from traits can only be used if the trait is implemented and in scope
    = note: the following trait defines an item `bar`, perhaps you need to implement it:
            candidate #1: `Bar`

Since they actually don't apply for this case.

Also, it might help to elaborate the lines before that, maybe an explicit mention of <Foo<Inner> as Bar>::bar() can be thrown in?

What do you think of the following output?

error[E0599]: no method named `bar` found for struct `Foo<Inner>` in the current scope
  --> file5.rs:21:9
   |
1  | struct Foo<T> {
   | ------------- method `bar` not found for this
...
5  | struct Inner {
   | ------------ this type doesn't satisfy the bound `std::clone::Clone`
...
21 |     foo.bar();
   |         ^^^ method not found in `Foo<Inner>`
   |
   = note: the method `bar` exists but the following trait bounds were not satisfied:
           `Inner: std::clone::Clone`
   = help: items from traits can only be used if the trait is implemented and in scope
   = note: the following trait defines an item `bar`, perhaps you need to implement it:
           candidate #1: `Bar`

I'll look into removing the last few lines as I agree that they are somewhat misleading here and obscure the solution, but we have to make sure we don't actually hide information useful for other cases with different underlying problems.

Yeah, this would be even better. I still think it would be nice to specifically call out Bar somewhere/somehow as the provider of bar() and the implementer specifying the trait bound (though it doesn't need the full location treatment).

What about this?

error[E0599]: no method named `bar` found for struct `Foo<Inner>` in the current scope
  --> file5.rs:24:9
   |
1  | struct Foo<T> {
   | ------------- method `bar` not found for this
...
5  | struct Inner {
   | ------------ the method `bar` but this type doesn't satisfy the bound `Inner: std::clone::Clone`
...
9  | trait Bar {
   | --------- this trait defines an item `bar`
...
24 |     foo.bar();
   |         ^^^ method not found in `Foo<Inner>`
   |
   = help: items from traits can only be used if the trait is implemented and in scope

I find the four separate span blocks a bit distracting. I would opt for something like this:

error[E0599]: no method named `bar` found for struct `Foo<Inner>` in the current scope
  --> file5.rs:24:9
   |
1  | struct Foo<T> {
   | ------------- method `bar` not found for this
...
5  | struct Inner {
   | ------------ this type doesn't satisfy the bound `Inner: std::clone::Clone`
   |
   = note: the method `bar` exists but the following trait bounds were not satisfied:
           `Inner: std::clone::Clone` which is required by `Foo<Inner>: Bar`
   = help: items from traits can only be used if the trait is implemented and in scope

On the other hand, a span block pointing to the impl Bar for Foo<Inner> might be useful.

The current output in the PR looks like this

error[E0599]: no method named `bar` found for struct `Foo<Inner>` in the current scope
  --> file5.rs:21:9
   |
1  | struct Foo<T> {
   | -------------
   | |
   | method `bar` not found for this
   | doesn't satisfy `Foo<Inner>: Bar`
...
5  | struct Inner {
   | ------------ doesn't satisfy `Inner: std::clone::Clone`
...
9  | trait Bar {
   | --------- `Bar` defines an item `bar`, perhaps you need to implement it
...
21 |     foo.bar();
   |         ^^^ method not found in `Foo<Inner>`
   |
   = note: the method `bar` exists but the following trait bounds were not satisfied:
           `Inner: std::clone::Clone` which is required by `Foo<Inner>: Bar`
   = help: items from traits can only be used if the trait is implemented and in scope

I'm a bit hesitant about removing spans at this point. It might be true that changing it to the following could be a good idea, but I'm not sure:

error[E0599]: no method named `bar` found for struct `Foo<Inner>` in the current scope
  --> file5.rs:21:9
   |
1  | struct Foo<T> {
   | ------------- method `bar` not found for this
...
5  | struct Inner {
   | ------------ doesn't satisfy `Inner: std::clone::Clone`
...
21 |     foo.bar();
   |         ^^^ method not found in `Foo<Inner>`
   |
   = note: the method `bar` exists but the following trait bounds were not satisfied:
           `Inner: std::clone::Clone` which is required by `Foo<Inner>: Bar`
   = help: items from traits can only be used if the trait is implemented and in scope
   = note: the following trait defines an item `bar`, perhaps you need to implement it:
           candidate #1: `Bar`

Let's see if we can get some wisdom from the crowd.

Rollup merge of rust-lang#69255 - estebank:e0599-details, r=varkor

Auto merge of #69255 - estebank:e0599-details, r=varkor

Navigation Menu

Repository navigation

Improve E0599 for missing trait bounds (where clauses) #61661

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Improve E0599 for missing trait bounds (where clauses) #61661

Description

Activity

estebank commented on Feb 18, 2020

djc commented on Feb 18, 2020

estebank commented on Feb 18, 2020

djc commented on Feb 18, 2020

estebank commented on Feb 18, 2020

djc commented on Feb 18, 2020

estebank commented on Feb 19, 2020

djc commented on Feb 20, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions