Repository navigation
Give the Unstable Book a title #59554
Description
Similar to rust-lang/rfcs#2669, but for the Unstable Book
Right now, titles look like: <title>emit_stack_sizes - </title>
To do this, we might just need to add a book.toml file in this directory
Activity
gruberb commentedon Mar 30, 2019
I created a PR for this issue. The title I added is "The Rust Unstable Book". Or should it just be "The Unstable Book"?
frewsxcv commentedon Mar 30, 2019
What you have looks great, thanks!
Rollup merge of rust-lang#59569 - gruberb:add-title-for-unstable-book…
Rollup merge of rust-lang#59569 - gruberb:add-title-for-unstable-book…
frewsxcv commentedon Apr 4, 2019
Looks like there's still no title set after #59569 🤔
gruberb commentedon Apr 4, 2019
Hmm... I'll check later when I am
home!
gruberb commentedon Apr 4, 2019
@frewsxcv I double checked and it seems it's not being able to compile since there is no
SUMMARY.md. When I run it locally the title is there, but the index is empty.So I'll add a
SUMMARY.mdand create a new PR.frewsxcv commentedon Apr 4, 2019
It's been a while since I looked at this code, so not entirely sure how it all works, but I think the summary.md file is generated here: https://github.com/rust-lang/rust/tree/master/src/tools/unstable-book-gen/src
gruberb commentedon Apr 4, 2019
I see. I took inspiration from the other books (like embedded). When I reproduce it for the unstable book, I get the title and everything.
So maybe I just have to add the
book.tomlto theunstable-book-genfolder. I never touched the books before so I am not sure why the unstable book behaves differently.ehuss commentedon Apr 5, 2019
@gruberb The unstable book is generated by a tool (
unstable-book-gen) which processes and copies the files fromsrc/doc/unstable-booktobuild/*/md-doc/unstable-bookand then mdbook is run against that folder to save the output tobuild/*/doc/unstable-book.I would probably edit
unstable-book-gento copy thebook.tomlfile over along with the source files.Rollup merge of rust-lang#59747 - gruberb:copy-book-toml-unstable-boo…
Rollup merge of rust-lang#59747 - gruberb:copy-book-toml-unstable-boo…
Rollup merge of rust-lang#59747 - gruberb:copy-book-toml-unstable-boo…
Rollup merge of rust-lang#59747 - gruberb:copy-book-toml-unstable-boo…
frewsxcv commentedon Apr 15, 2019
seems to be working now, thanks @gruberb!
https://doc.rust-lang.org/nightly/unstable-book/language-features/infer-static-outlives-requirements.html