Skip to content

x86 C ABI struct return does not work on windows/mac for structs < 8 bytes #5745

Closed
Closed
x86 C ABI struct return does not work on windows/mac for structs < 8 bytes#5745
Labels
A-codegenArea: Code generationO-macosOperating system: macOSO-windowsOperating system: Windows

Description

@brson
brson
opened on Apr 5, 2013

C returns the structs packed into %eax but our code appears to load the fields from %al and %dl for byte fields.

See run-pass/extern-return-TwoU8s and run-pass/extern-return-TwoU16s.

Activity

  1. brson commented on Apr 18, 2013

    @brson
    brson
    on Apr 18, 2013
    ContributorAuthor

    Mac appears to follow the same ABI as windows here.

  2. pnkfelix commented on Aug 29, 2013

    @pnkfelix
    pnkfelix
    on Aug 29, 2013
    Contributor

    visiting for bug traige, 2013-08-26.

    Nominating for maturity milestone 3: Feature Complete.

  3. pnkfelix commented on Aug 29, 2013

    @pnkfelix
    pnkfelix
    on Aug 29, 2013
    Contributor

    accepted for feature complete

  4. nikomatsakis commented on Aug 29, 2013

    @nikomatsakis
    nikomatsakis
    on Aug 29, 2013
    Contributor

    Those test cases work now (I fixed this as part of my extern fn work)

  5. nikomatsakis
    closed this as completedon Aug 29, 2013
  6. flip1995
    added a commit that references this issue on Jul 14, 2020

    Auto merge of rust-lang#5745 - montrivo:copy_on_clone, r=phansch

    a14eab3
  7. U007D
    added a commit that references this issue on Aug 21, 2026

    Merge rust-lang#5745

    c2b1503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-codegenArea: Code generationO-macosOperating system: macOSO-windowsOperating system: Windows

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions