Repository navigation
No nightly on 2018-12-07 #56586
Description
Activity
- addedT-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.C-bugCategory: This is a bug.Category: This is a bug.
on Dec 7, 2018 Dec 7 00:03:38 ip-10-202-181-185 release-nightly: Updating submodule src/tools/miri Dec 7 00:03:38 ip-10-202-181-185 release-nightly: fatal: reference is not a tree: 61f20761d3124f5a1b1caee8aa15637cc7f92d8e Dec 7 00:03:38 ip-10-202-181-185 release-nightly: Unable to checkout '61f20761d3124f5a1b1caee8aa15637cc7f92d8e' in submodule path 'src/tools/miri' Dec 7 00:03:38 ip-10-202-181-185 release-nightly: failed to run: git submodule update --init --recursive src/tools/miri@RalfJung or @oli-obk was miri force-pushed recently perhaps?
No, but I made a PR updating miri to a commit that's in a miri PR, not in miri master. Because GH adds PR commits to the target repo I thought that should work, and it did work locally and on CI.
I now made a branch in the miri repo containing that commit, I don't know if having it in a branch vs. a PR makes a difference though (I think it should not).
Is the release machine using an ancient version of git? Seems like the same problem that @jethrogb had (#56307 (comment)) with git 2.7 (which is almost 3 years old).
This should sort itself out then, now that the commit is available upstream, no? But yeah, it would be good if such things were caught in CI. I think it would be reasonable to configure git in the most conservative way w.r.t. finding commits.
I got same issue with git 2.19.
Now that is strange. I don't have this issue.
$ git --version git version 2.19.2How do you reproduce this?
giton RCS is currently 2.7.4 so that might explain at least part of the problem. I've filed rust-lang/rust-central-station#119 to try and update the Ubuntu used for RCS...We got a nightly last night, so closing! I think this is otherwise diagnosed and being fixed
As you can see, the latest nightly still has a commit dating from 2018-12-05, meaning it is the nightly created on 2018-12-06 (shortly after midnight). There was no nightly created today.
Cc @rust-lang/infra