Tracking issue for std::ptr::hash #56286

Activity

1. Centril

   added

   T-libs-api[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

   C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFC

   on Nov 27, 2018
2. alexcrichton

   added

   B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.

   on Dec 4, 2018
3. dtolnay commented on Dec 13, 2018

   

   dtolnay

   on Dec 13, 2018

   Member

   More actions

   Updated from:

   fn hash<T, S: Hasher>(hashee: *const T, into: &mut S)

   to:

   fn hash<T: ?Sized, S: Hasher>(hashee: *const T, into: &mut S)
              ^^^^^^

   in #56751. Thanks @mbrubeck.
4. SimonSapin commented on Feb 1, 2019

   

   SimonSapin

   on Feb 1, 2019

   Contributor

   More actions

   Seems straightforward enough to me.

   @rfcbot fcp merge
5. rfcbot commented on Feb 1, 2019

   

   rfcbot

   on Feb 1, 2019

   Last edited by sfackler

   More actions

   Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

   • @Kimundi
   • @SimonSapin
   • @alexcrichton
   • @dtolnay
   • @sfackler
   • @withoutboats

   No concerns currently listed.

   Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

   See this document for info about what commands tagged team members can give me.
6. rfcbot

   added

   proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

   disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.This issue / PR is in PFCP or FCP with a disposition to merge it.

   on Feb 1, 2019
7. rfcbot commented on Feb 8, 2019

   

   rfcbot

   on Feb 8, 2019

   More actions

   🔔 This is now entering its final comment period, as per the review above. 🔔
8. rfcbot

   added

   final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.

   and removed

   proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

   on Feb 8, 2019
9. rfcbot

   added

   finished-final-comment-periodThe final comment period is finished for this PR / Issue.The final comment period is finished for this PR / Issue.

   on Feb 18, 2019
10. rfcbot commented on Feb 18, 2019

    

    rfcbot

    on Feb 18, 2019

    More actions

    The final comment period, with a disposition to merge, as per the review above, is now complete.
11. rfcbot

    removed

    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.

    on Feb 18, 2019
12. Centril

    added

    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    on Mar 26, 2019
13. matklad

    added a commit that references this issue on Apr 1, 2019

    stabilize ptr::hash

    ...

    This issue will close once commit a240c59 is merged into the 'master' branch.

    a240c59
14. Centril

    added a commit that references this issue on Apr 1, 2019

    Rollup merge of rust-lang#59603 - matklad:ptrhash, r=Centril

    ...

    This issue will close once commit e9b9f33 is merged into the 'master' branch.

    e9b9f33
15. bors

    closed this as completedin #59603on Apr 1, 2019
16. matklad commented on Jul 3, 2019

    

    matklad

    on Jul 3, 2019

    Contributor

    More actions

    Question:

    We have Arc::ptr_eq, should we have Arc::ptr_hash as well?
17. SimonSapin commented on Jul 3, 2019

    

    SimonSapin

    on Jul 3, 2019

    Contributor

    More actions

    We could, but that’s going quickly into diminishing returns IMO. You can always use something like std::ptr::hash::<T, _>(&*arc, s)