Write to #[thread_local] is not respected

#![feature(thread_local)]

#[thread_local]
static S: &str = "before";

fn set_s() {
    S = "after";
}

fn main() {
    println!("{}", S);
    set_s();
    println!("{}", S);
}

On rustc 1.31.0-nightly (b2d6ea9 2018-10-07) and x86_64-unknown-linux-gnu, we see the following surprising behavior:

$ cargo run  # as expected
before
after

$ cargo run --release
before
before

In release mode it seems the write has not happened in the place that it should.

Mentioning thread_local tracking issue: rust-lang/rust#29594.

Ah, apparently this is missing a mut. With mut the behavior is correct. We need to make sure mutating a thread_local static that does not have mut does not compile.

#![feature(thread_local)]

#[thread_local]
static mut S: &str = "before";

fn set_s() {
    unsafe { S = "after" };
}

fn main() {
    println!("{}", unsafe { S });
    set_s();
    println!("{}", unsafe { S });
}

$ cargo run --release
before
after

@pnkfelix

cc @pnkfelix @nikomatsakis Did #55150 fix this by any chance?

It looks like this is fixed on nightly; I'm guessing #55150 is the reason. We probably should add some regression tests for the cases listed here.

Rollup merge of rust-lang#57107 - mjbshaw:thread_local_test, r=nikoma…

Navigation Menu

Repository navigation

Write to #[thread_local] is not respected #54901

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Write to #[thread_local] is not respected #54901

Description

Activity

dtolnay commented on Oct 8, 2018

eddyb commented on Nov 4, 2018

pnkfelix commented on Nov 5, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions