ICE when existential type is exported from one crate and used in another #53443

Activity

1. oli-obk commented on Aug 17, 2018

   

   oli-obk

   on Aug 17, 2018

   Contributor

   More actions

   Oops. Yea. I assumed this would work since impl Trait works.
2. oli-obk

   added

   I-ICEIssue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️

   A-impl-traitArea: `impl Trait`. Universally / existentially quantified anonymous types with static dispatch.Area: `impl Trait`. Universally / existentially quantified anonymous types with static dispatch.

   on Aug 17, 2018
3. Arnavion commented on Aug 17, 2018

   

   Arnavion

   on Aug 17, 2018

   ContributorAuthor

   More actions

   Is the fix just to have self.define(parent, ident, TypeNS, (def, vis, DUMMY_SP, expansion)); ? I added that and it passes the repro in the OP, but my real code triggers another ICE at:

   rust/src/librustc/middle/resolve_lifetime.rs

   Line 630 in b559042

   let id = self.tcx.hir.as_local_node_id(exist_ty_did).unwrap();

   where the as_local_node_id returns None

   If you think the fix for this ICE is just that one self.define() call, I can start making a minimal repro for this second ICE too.
4. oli-obk commented on Aug 20, 2018

   

   oli-obk

   on Aug 20, 2018

   Contributor

   More actions

   I think they are closely related. We should probably run

   {
                               intravisit::walk_ty(self, ty);
                               return;
   }

   in case as_local_node_id returns None. A repro for that would be nice though. It should probably suffice to add some lifetimes to the existential type or its concrete type.
5. Arnavion commented on Aug 20, 2018

   

   Arnavion

   on Aug 20, 2018

   ContributorAuthor

   More actions

   My real code's existential types do not have lifetimes, though they do have 'static bounds.

   pub existential type GetResponse: Future<Output = crate::Result<crate::Mod>> + 'static;
   pub existential type DownloadResponse: Stream<Item = crate::Result<crate::reqwest_async::Chunk>> + 'static;

   Adding 'static bounds to the OP code did not repro the same crash.

   The concrete type for the first one is compiler-created because it's the return type of an async block.

   pub fn get(&self, mod_name: &factorio_mods_common::ModName) -> GetResponse {
       ...
       async {
           ....
       }
   }

   I believe this is sugar for std::future::GenFuture, so that should also not have any lifetimes.

   The second one's concrete type is my own Stream impl that also does not have lifetimes.

   It'll take me some time to get a repro because something is broken with the rustc I built locally (it started hitting #53469 even though it was fine before, not sure why). If you want you can find the real code at https://github.com/Arnavion/fac-rs/tree/3a6afed4. The existential types are in the factorio-mods-web crate and imported by the workspace root crate. It won't compile because I'm still in the process of migrating it to std::future, but atleast it shouldn't ICE.
6. oli-obk commented on Aug 21, 2018

   

   oli-obk

   on Aug 21, 2018

   Contributor

   More actions

   factorio-mods-web

   Rust + factorio? <3

   It'll take me some time to get a repro because something is broken with the rustc I built locally

   the issue you are hitting is that a delay_span_bug is hidden from you. I'm fixing that later today
7. Arnavion commented on Aug 22, 2018

   

   Arnavion

   on Aug 22, 2018

   Last edited by Arnavion

   ContributorAuthor

   More actions

   @oli-obk The #53469 I started hitting was because of two different versions of libsyntax_pos in stage1 builds, as I described here. So with stage2 builds I don't have that problem,

   So I've got a repro for the issue where as_local_node_id returns None. It happens when using the imported existential type in a struct or enum definition, like:

   b/src/main.rs

   extern crate a;
   
   struct Bar(a::Foo);
   
   fn main() {
   }

   ICE

   thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', libcore\option.rs:345:21
   stack backtrace:
      0: std::sys::windows::backtrace::unwind_backtrace
                at C:\Stuff\Sources\rustsrc\src\libstd\sys\windows\backtrace\mod.rs:95
      1: std::sys_common::backtrace::print
                at C:\Stuff\Sources\rustsrc\src\libstd\sys_common\backtrace.rs:59
      2: std::panicking::default_hook::{{closure}}
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:211
      3: std::panicking::default_hook
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:227
      4: rustc::util::common::panic_hook
                at C:\Stuff\Sources\rustsrc\src\librustc\util\common.rs:51
      5: std::panicking::rust_panic_with_hook
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:479
      6: std::panicking::continue_panic_fmt
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:390
      7: std::panicking::rust_begin_panic
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:325
      8: core::panicking::panic_fmt
                at C:\Stuff\Sources\rustsrc\src\libcore\panicking.rs:77
      9: core::panicking::panic
                at C:\Stuff\Sources\rustsrc\src\libcore\panicking.rs:52
     10: rustc::middle::resolve_lifetime::{{impl}}::visit_ty
                at C:\Stuff\Sources\rustsrc\src\librustc\middle\resolve_lifetime.rs:626
     11: rustc::hir::intravisit::walk_item<rustc::middle::resolve_lifetime::LifetimeContext>
                at C:\Stuff\Sources\rustsrc\src\librustc\hir\intravisit.rs:539
     12: rustc::middle::resolve_lifetime::{{impl}}::visit_item
                at C:\Stuff\Sources\rustsrc\src\librustc\middle\resolve_lifetime.rs:539
     13: rustc::middle::resolve_lifetime::resolve_lifetimes
                at C:\Stuff\Sources\rustsrc\src\librustc\middle\resolve_lifetime.rs:392
     14: rustc::ty::query::{{impl}}::compute
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:820
     15: rustc::ty::context::tls::with_context<closure,alloc::rc::Rc<rustc::middle::privacy::AccessLevels<syntax::ast::NodeId>>>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1953
     16: rustc::dep_graph::graph::DepGraph::with_task_impl<rustc::ty::context::TyCtxt,rustc::hir::def_id::CrateNum,alloc::rc::Rc<rustc::middle::resolve_lifetime::ResolveLifetimes>>
                at C:\Stuff\Sources\rustsrc\src\librustc\dep_graph\graph.rs:266
     17: rustc::ty::context::tls::with_related_context<closure,(alloc::rc::Rc<rustc::middle::resolve_lifetime::ResolveLifetimes>, rustc::dep_graph::graph::DepNodeIndex)>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1964
     18: rustc::ty::context::TyCtxt::force_query_with_job<rustc::ty::query::queries::resolve_lifetimes>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:543
     19: rustc::ty::context::TyCtxt::get_query<rustc::ty::query::queries::resolve_lifetimes>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:640
     20: core::ops::function::FnOnce::call_once<closure,(rustc::ty::context::TyCtxt, rustc::hir::def_id::DefIndex)>
                at C:\Stuff\Sources\rustsrc\src\libcore\ops\function.rs:238
     21: rustc::ty::query::{{impl}}::compute
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:820
     22: rustc::ty::context::tls::with_context<closure,alloc::rc::Rc<rustc::middle::privacy::AccessLevels<syntax::ast::NodeId>>>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1953
     23: rustc::dep_graph::graph::DepGraph::with_task_impl<rustc::ty::context::TyCtxt,rustc::hir::def_id::DefIndex,core::option::Option<alloc::rc::Rc<std::collections::hash::map::HashMap<rustc::hir::ItemLocalId, alloc::rc::Rc<alloc::vec::Vec<rustc::middle::resolve_lifetime::Set1<rustc::middle::resolve_lifetime::Region>>>, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>>>
                at C:\Stuff\Sources\rustsrc\src\librustc\dep_graph\graph.rs:266
     24: rustc::ty::context::tls::with_related_context<closure,(core::option::Option<alloc::rc::Rc<std::collections::hash::map::HashMap<rustc::hir::ItemLocalId, alloc::rc::Rc<alloc::vec::Vec<rustc::middle::resolve_lifetime::Set1<rustc::middle::resolve_lifetime::Region>>>, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>>, rustc::dep_graph::graph::DepNodeIndex)>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1964
     25: rustc::ty::context::TyCtxt::force_query_with_job<rustc::ty::query::queries::object_lifetime_defaults_map>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:543
     26: rustc::ty::context::TyCtxt::get_query<rustc::ty::query::queries::object_lifetime_defaults_map>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:640
     27: rustc::ty::context::TyCtxt::object_lifetime_defaults
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:2787
     28: rustc_typeck::collect::generics_of
                at C:\Stuff\Sources\rustsrc\src\librustc_typeck\collect.rs:915
     29: rustc::ty::query::__query_compute::generics_of<closure,rustc::ty::Generics*>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:790
     30: rustc::ty::query::{{impl}}::compute
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:820
     31: rustc::ty::context::tls::with_context<closure,alloc::rc::Rc<rustc::traits::specialize::specialization_graph::Graph>>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1953
     32: rustc::dep_graph::graph::DepGraph::with_task_impl<rustc::ty::context::TyCtxt,rustc::hir::def_id::DefId,rustc::ty::Generics*>
                at C:\Stuff\Sources\rustsrc\src\librustc\dep_graph\graph.rs:266
     33: rustc::ty::context::tls::with_related_context<closure,(rustc::ty::Generics*, rustc::dep_graph::graph::DepNodeIndex)>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1964
     34: rustc::ty::context::TyCtxt::force_query_with_job<rustc::ty::query::queries::generics_of>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:543
     35: rustc::ty::context::TyCtxt::get_query<rustc::ty::query::queries::generics_of>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:640
     36: rustc::ty::context::TyCtxt::generics_of
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:869
     37: rustc_typeck::collect::{{impl}}::visit_item
                at C:\Stuff\Sources\rustsrc\src\librustc_typeck\collect.rs:113
     38: rustc::hir::Crate::visit_all_item_likes<rustc::hir::itemlikevisit::DeepVisitor<rustc_typeck::collect::CollectItemTypesVisitor>>
                at C:\Stuff\Sources\rustsrc\src\librustc\hir\mod.rs:719
     39: rustc::util::common::time<(),closure>
                at C:\Stuff\Sources\rustsrc\src\librustc\util\common.rs:157
     40: rustc_typeck::check_crate
                at C:\Stuff\Sources\rustsrc\src\librustc_typeck\lib.rs:342
     41: rustc::ty::context::tls::enter_context<closure,core::result::Result<core::result::Result<(rustc::session::config::OutputFilenames, alloc::boxed::Box<Any>, rustc::dep_graph::graph::DepGraph), rustc::session::CompileIncomplete>, rustc::session::CompileIncomplete>>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1868
     42: std::thread::local::LocalKey<core::cell::Cell<fn(syntax_pos::span_encoding::Span, mut core::fmt::Formatter*) -> core::result::Result<(), core::fmt::Error>>>::with<core::cell::Cell<fn(syntax_pos::span_encoding::Span, mut core::fmt::Formatter*) -> core::result::Result<(), core::fmt::Error>>,closure,core::result::Result<core::result::Result<(rustc::session::config::OutputFilenames, alloc::boxed
   ::Box<Any>, rustc::dep_graph::graph::DepGraph), rustc::session::CompileIncomplete>, rustc::session::CompileIncomplete>>
                at C:\Stuff\Sources\rustsrc\src\libstd\thread\local.rs:248
     43: rustc::ty::context::TyCtxt::create_and_enter<closure,core::result::Result<core::result::Result<(rustc::session::config::OutputFilenames, alloc::boxed::Box<Any>, rustc::dep_graph::graph::DepGraph), rustc::session::CompileIncomplete>, rustc::session::CompileIncomplete>>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1186
     44: rustc_driver::driver::compile_input
                at C:\Stuff\Sources\rustsrc\src\librustc_driver\driver.rs:285
     45: rustc_driver::run_compiler_with_pool
                at C:\Stuff\Sources\rustsrc\src\librustc_driver\lib.rs:562
     46: scoped_tls::ScopedKey<syntax::Globals>::set<syntax::Globals,closure,(core::result::Result<(), rustc::session::CompileIncomplete>, core::option::Option<rustc::session::Session>)>
                at C:\Users\Arnavion\.cargo\registry\src\github.life-white.uk-1ecc6299db9ec823\scoped-tls-0.1.2\src\lib.rs:155
     47: std::panic::{{impl}}::call_once<(),closure>
                at C:\Stuff\Sources\rustsrc\src\libstd\panic.rs:313
     48: panic_unwind::__rust_maybe_catch_panic
                at C:\Stuff\Sources\rustsrc\src\libpanic_unwind\lib.rs:102
     49: std::panicking::try<(),std::panic::AssertUnwindSafe<closure>>
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:289
     50: rustc_driver::run<closure>
                at C:\Stuff\Sources\rustsrc\src\librustc_driver\lib.rs:187
     51: rustc_driver::main
                at C:\Stuff\Sources\rustsrc\src\librustc_driver\lib.rs:1737
     52: std::rt::lang_start::{{closure}}<()>
                at C:\Stuff\Sources\rustsrc\src\libstd\rt.rs:74
     53: std::panicking::try::do_call<closure,i32>
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:310
     54: panic_unwind::__rust_maybe_catch_panic
                at C:\Stuff\Sources\rustsrc\src\libpanic_unwind\lib.rs:102
     55: std::panicking::try<i32,closure>
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:289
     56: std::rt::lang_start_internal
                at C:\Stuff\Sources\rustsrc\src\libstd\rt.rs:58
     57: main
     58: __scrt_common_main_seh
                at f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:288
     59: BaseThreadInitThunk
     60: RtlUserThreadStart
   query stack during panic:
   #0 [resolve_lifetimes] resolving lifetimes
   #1 [object_lifetime_defaults_map] looking up lifetime defaults for a region
   #2 [generics_of] processing `Bar`
   end of query stack
   
8. Arnavion commented on Aug 23, 2018

   

   Arnavion

   on Aug 23, 2018

   ContributorAuthor

   More actions

   Your suggestion did fix that error by the way.

   --- a/src/librustc/middle/resolve_lifetime.rs
   +++ b/src/librustc/middle/resolve_lifetime.rs
   @@ -623,7 +623,13 @@ impl<'a, 'tcx> Visitor<'tcx> for LifetimeContext<'a, 'tcx> {
                }
                hir::TyKind::Path(hir::QPath::Resolved(None, ref path)) => {
                    if let Def::Existential(exist_ty_did) = path.def {
   -                    let id = self.tcx.hir.as_local_node_id(exist_ty_did).unwrap();
   +                    let id = match self.tcx.hir.as_local_node_id(exist_ty_did) {
   +                        Some(id) => id,
   +                        None => {
   +                            intravisit::walk_ty(self, ty);
   +                            return;
   +                        },
   +                    };
   
                        // Resolve the lifetimes in the bounds to the lifetime defs in the generics.
                        // `fn foo<'a>() -> impl MyTrait<'a> { ... }` desugars to
9. Arnavion commented on Aug 24, 2018

   

   Arnavion

   on Aug 24, 2018

   ContributorAuthor

   More actions

   With the above patch, there is a new ICE when using the field inside an inherent method.

   extern crate a;
   
   struct Bar(a::Foo);
   
   impl Bar {
   	fn zero(&self) -> &a::Foo {
   		&self.0
   	}
   }
   
   fn main() {
   }

   ICE

   thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', libcore\option.rs:345:21
   stack backtrace:
      0: std::sys::windows::backtrace::unwind_backtrace
                at C:\Stuff\Sources\rustsrc\src\libstd\sys\windows\backtrace\mod.rs:95
      1: std::sys_common::backtrace::print
                at C:\Stuff\Sources\rustsrc\src\libstd\sys_common\backtrace.rs:59
      2: std::panicking::default_hook::{{closure}}
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:211
      3: std::panicking::default_hook
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:227
      4: rustc::util::common::panic_hook
                at C:\Stuff\Sources\rustsrc\src\librustc\util\common.rs:51
      5: std::panicking::rust_panic_with_hook
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:479
      6: std::panicking::continue_panic_fmt
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:390
      7: std::panicking::rust_begin_panic
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:325
      8: core::panicking::panic_fmt
                at C:\Stuff\Sources\rustsrc\src\libcore\panicking.rs:77
      9: core::panicking::panic
                at C:\Stuff\Sources\rustsrc\src\libcore\panicking.rs:52
     10: rustc::ty::fold::{{impl}}::fold_ty<closure,closure>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\fold.rs:221
     11: rustc::ty::structural_impls::{{impl}}::super_fold_with<rustc::ty::fold::BottomUpFolder<closure, closure>>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\structural_impls.rs:851
     12: rustc::ty::fold::{{impl}}::fold_ty<closure,closure>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\fold.rs:219
     13: rustc_typeck::check::wfcheck::check_where_clauses
                at C:\Stuff\Sources\rustsrc\src\librustc_typeck\check\wfcheck.rs:503
     14: rustc_typeck::check::wfcheck::check_fn_or_method
                at C:\Stuff\Sources\rustsrc\src\librustc_typeck\check\wfcheck.rs:544
     15: rustc::ty::context::tls::with_related_context<closure,()>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1964
     16: rustc::infer::InferCtxtBuilder::enter<closure,()>
                at C:\Stuff\Sources\rustsrc\src\librustc\infer\mod.rs:469
     17: rustc_typeck::check::wfcheck::check_associated_item
                at C:\Stuff\Sources\rustsrc\src\librustc_typeck\check\wfcheck.rs:182
     18: rustc_typeck::check::wfcheck::check_impl_item
                at C:\Stuff\Sources\rustsrc\src\librustc_typeck\check\wfcheck.rs:174
     19: rustc::ty::query::{{impl}}::compute
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:820
     20: rustc::ty::context::tls::with_context<closure,()>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1953
     21: rustc::dep_graph::graph::DepGraph::with_task_impl<rustc::ty::context::TyCtxt,rustc::hir::def_id::DefId,()>
                at C:\Stuff\Sources\rustsrc\src\librustc\dep_graph\graph.rs:266
     22: rustc::ty::context::tls::with_related_context<closure,((), rustc::dep_graph::graph::DepNodeIndex)>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1964
     23: rustc::ty::context::TyCtxt::force_query_with_job<rustc::ty::query::queries::check_impl_item_well_formed>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:543
     24: rustc::ty::context::TyCtxt::get_query<rustc::ty::query::queries::check_impl_item_well_formed>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:640
     25: rustc::ty::context::TyCtxt::ensure_query<rustc::ty::query::queries::check_impl_item_well_formed>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\query\plumbing.rs:602
     26: rustc_typeck::check::wfcheck::{{impl}}::visit_impl_item
                at C:\Stuff\Sources\rustsrc\src\librustc_typeck\check\wfcheck.rs:934
     27: rustc::hir::Crate::visit_all_item_likes<rustc::hir::itemlikevisit::DeepVisitor<rustc_typeck::check::wfcheck::CheckTypeWellFormedVisitor>>
                at C:\Stuff\Sources\rustsrc\src\librustc\hir\mod.rs:727
     28: rustc::session::Session::track_errors<closure,()>
                at C:\Stuff\Sources\rustsrc\src\librustc\session\mod.rs:320
     29: rustc::util::common::time<core::result::Result<(), rustc::util::common::ErrorReported>,closure>
                at C:\Stuff\Sources\rustsrc\src\librustc\util\common.rs:157
     30: rustc_typeck::check_crate
                at C:\Stuff\Sources\rustsrc\src\librustc_typeck\lib.rs:368
     31: rustc::ty::context::tls::enter_context<closure,core::result::Result<core::result::Result<(rustc::session::config::OutputFilenames, alloc::boxed::Box<Any>, rustc::dep_graph::graph::DepGraph), rustc::session::CompileIncomplete>, rustc::session::CompileIncomplete>>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1868
     32: std::thread::local::LocalKey<core::cell::Cell<fn(syntax_pos::span_encoding::Span, mut core::fmt::Formatter*) -> core::result::Result<(), core::fmt::Error>>>::with<core::cell::Cell<fn(syntax_pos::span_encoding::Span, mut core::fmt::Formatter*) -> core::result::Result<(), core::fmt::Error>>,closure,core::result::Result<core::result::Result<(rustc::session::config::OutputFilenames, alloc::boxed::Box<Any>, rustc::dep_graph::graph::DepGraph), rustc::session::CompileIncomplete>, rustc::session::CompileIncomplete>>
                at C:\Stuff\Sources\rustsrc\src\libstd\thread\local.rs:248
     33: rustc::ty::context::TyCtxt::create_and_enter<closure,core::result::Result<core::result::Result<(rustc::session::config::OutputFilenames, alloc::boxed::Box<Any>, rustc::dep_graph::graph::DepGraph), rustc::session::CompileIncomplete>, rustc::session::CompileIncomplete>>
                at C:\Stuff\Sources\rustsrc\src\librustc\ty\context.rs:1186
     34: rustc_driver::driver::compile_input
                at C:\Stuff\Sources\rustsrc\src\librustc_driver\driver.rs:285
     35: rustc_driver::run_compiler_with_pool
                at C:\Stuff\Sources\rustsrc\src\librustc_driver\lib.rs:562
     36: scoped_tls::ScopedKey<syntax::Globals>::set<syntax::Globals,closure,(core::result::Result<(), rustc::session::CompileIncomplete>, core::option::Option<rustc::session::Session>)>
                at C:\Users\Arnavion\.cargo\registry\src\github.life-white.uk-1ecc6299db9ec823\scoped-tls-0.1.2\src\lib.rs:155
     37: std::panic::{{impl}}::call_once<(),closure>
                at C:\Stuff\Sources\rustsrc\src\libstd\panic.rs:313
     38: panic_unwind::__rust_maybe_catch_panic
                at C:\Stuff\Sources\rustsrc\src\libpanic_unwind\lib.rs:102
     39: std::panicking::try<(),std::panic::AssertUnwindSafe<closure>>
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:289
     40: rustc_driver::run<closure>
                at C:\Stuff\Sources\rustsrc\src\librustc_driver\lib.rs:187
     41: rustc_driver::main
                at C:\Stuff\Sources\rustsrc\src\librustc_driver\lib.rs:1737
     42: std::rt::lang_start::{{closure}}<()>
                at C:\Stuff\Sources\rustsrc\src\libstd\rt.rs:74
     43: std::panicking::try::do_call<closure,i32>
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:310
     44: panic_unwind::__rust_maybe_catch_panic
                at C:\Stuff\Sources\rustsrc\src\libpanic_unwind\lib.rs:102
     45: std::panicking::try<i32,closure>
                at C:\Stuff\Sources\rustsrc\src\libstd\panicking.rs:289
     46: std::rt::lang_start_internal
                at C:\Stuff\Sources\rustsrc\src\libstd\rt.rs:58
     47: main
     48: __scrt_common_main_seh
                at f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:288
     49: BaseThreadInitThunk
     50: RtlUserThreadStart
   query stack during panic:
   #0 [check_impl_item_well_formed] processing `Bar::zero`
   end of query stack
   
10. andreytkachenko commented on Aug 30, 2018

    

    andreytkachenko

    on Aug 30, 2018

    Last edited by andreytkachenko

    Contributor

    More actions

    For me another variant of this issues is blocker:

    a/Cargo.toml and b/Cargo.toml - is same
    a/src/lib.rs:

    #![feature(existential_type)]
    
    pub trait View {
        type Tmp: Iterator<Item = u32>;
    
        fn test(&self) -> Self::Tmp;
    }
    
    pub struct X;
    
    impl View for X {
        existential type Tmp: Iterator<Item = u32>;
    
        fn test(&self) -> Self::Tmp {
            vec![1,2,3].into_iter()
        }
    }

    and b/src/main.rs:

    extern crate a;
    use a::View;
    
    fn main() {
        let v = a::X;
        v.test();
    }

    ICE

    error: internal compiler error: librustc_metadata/decoder.rs:834: cannot get associated-item of `DefKey { parent: Some(DefIndex(0:7)), disambiguated_data: DisambiguatedDefPathData { data: AssocExistentialInImpl("Tmp"), disambiguator: 0 } }`
    
    thread 'main' panicked at 'Box<Any>', librustc_errors/lib.rs:586:9
    stack backtrace:
       0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
                 at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
       1: std::sys_common::backtrace::print
                 at libstd/sys_common/backtrace.rs:71
                 at libstd/sys_common/backtrace.rs:59
       2: std::panicking::default_hook::{{closure}}
                 at libstd/panicking.rs:211
       3: std::panicking::default_hook
                 at libstd/panicking.rs:227
       4: rustc::util::common::panic_hook
       5: std::panicking::rust_panic_with_hook
                 at libstd/panicking.rs:481
       6: std::panicking::begin_panic
       7: rustc_errors::Handler::bug
       8: rustc::util::bug::opt_span_bug_fmt::{{closure}}
       9: rustc::ty::context::tls::with_opt::{{closure}}
      10: rustc::ty::context::tls::with_context_opt
      11: rustc::ty::context::tls::with_opt
      12: rustc::util::bug::opt_span_bug_fmt
      13: rustc::util::bug::bug_fmt
      14: rustc_metadata::decoder::<impl rustc_metadata::cstore::CrateMetadata>::get_associated_item
      15: rustc_metadata::cstore_impl::provide_extern::associated_item
      16: rustc::ty::query::__query_compute::associated_item
      17: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors<'tcx> for rustc::ty::query::queries::associated_item<'tcx>>::compute
      18: rustc::ty::context::tls::with_context
      19: rustc::dep_graph::graph::DepGraph::with_task_impl
      20: <rustc::ty::query::plumbing::JobOwner<'a, 'tcx, Q>>::start
      21: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::force_query_with_job
      22: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::get_query
      23: <core::iter::Map<I, F> as core::iter::iterator::Iterator>::next
      24: rustc::traits::project::assoc_ty_def
      25: rustc::infer::InferCtxt::commit_if_ok
      26: rustc::traits::project::opt_normalize_projection_type
      27: rustc::traits::project::normalize_projection_type
      28: <rustc::traits::project::AssociatedTypeNormalizer<'a, 'b, 'gcx, 'tcx> as rustc::ty::fold::TypeFolder<'gcx, 'tcx>>::fold_ty
      29: <rustc_data_structures::accumulate_vec::AccumulateVec<A> as core::iter::traits::FromIterator<<A as rustc_data_structures::array_vec::Array>::Element>>::from_iter
      30: rustc::ty::fold::TypeFoldable::fold_with
      31: rustc::infer::InferCtxt::partially_normalize_associated_types_in
      32: rustc_typeck::check::method::confirm::ConfirmContext::confirm
      33: rustc_typeck::check::FnCtxt::check_expr_kind
      34: rustc_typeck::check::FnCtxt::check_expr_with_expectation_and_needs
      35: rustc_typeck::check::FnCtxt::check_block_with_expected
      36: rustc_typeck::check::FnCtxt::check_expr_kind
      37: rustc_typeck::check::FnCtxt::check_expr_with_expectation_and_needs
      38: rustc_typeck::check::FnCtxt::check_return_expr
      39: rustc_typeck::check::check_fn
      40: rustc::ty::context::tls::with_related_context
      41: rustc::infer::InferCtxtBuilder::enter
      42: rustc_typeck::check::typeck_tables_of
      43: rustc::ty::query::__query_compute::typeck_tables_of
      44: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors<'tcx> for rustc::ty::query::queries::typeck_tables_of<'tcx>>::compute
      45: rustc::ty::context::tls::with_context
      46: rustc::dep_graph::graph::DepGraph::with_task_impl
      47: <rustc::ty::query::plumbing::JobOwner<'a, 'tcx, Q>>::start
      48: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::force_query_with_job
      49: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::get_query
      50: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::ensure_query
      51: rustc_typeck::check::typeck_item_bodies
      52: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors<'tcx> for rustc::ty::query::queries::typeck_item_bodies<'tcx>>::compute
      53: rustc::ty::context::tls::with_context
      54: rustc::dep_graph::graph::DepGraph::with_task_impl
      55: <rustc::ty::query::plumbing::JobOwner<'a, 'tcx, Q>>::start
      56: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::force_query_with_job
      57: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::get_query
      58: rustc_typeck::check_crate
      59: rustc::ty::context::tls::enter_context
      60: <std::thread::local::LocalKey<T>>::with
      61: rustc::ty::context::TyCtxt::create_and_enter
      62: rustc_driver::driver::compile_input
      63: rustc_driver::run_compiler_with_pool
      64: <scoped_tls::ScopedKey<T>>::set
      65: <scoped_tls::ScopedKey<T>>::set
      66: syntax::with_globals
      67: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
      68: __rust_maybe_catch_panic
                 at libpanic_unwind/lib.rs:102
      69: rustc_driver::run
      70: rustc_driver::main
      71: std::rt::lang_start::{{closure}}
      72: std::panicking::try::do_call
                 at libstd/rt.rs:59
                 at libstd/panicking.rs:310
      73: __rust_maybe_catch_panic
                 at libpanic_unwind/lib.rs:102
      74: std::rt::lang_start_internal
                 at libstd/panicking.rs:289
                 at libstd/panic.rs:392
                 at libstd/rt.rs:58
      75: main
      76: __libc_start_main
      77: <unknown>
    query stack during panic:
    #0 [associated_item] processing `<a::X as a::View>::Tmp`
    #1 [typeck_tables_of] processing `main`
    #2 [typeck_item_bodies] type-checking all item bodies
    end of query stack
    
11. tikue commented on Sep 19, 2018

    

    tikue

    on Sep 19, 2018

    Contributor

    More actions

    Is there any progress on this?
12. tikue commented on Oct 15, 2018

    

    tikue

    on Oct 15, 2018

    Contributor

    More actions

    @Arnavion how do you feel about making a PR with your patch that has a partial fix? It looks like that would be enough to unblock me from using existential types in my project.
13. Arnavion commented on Oct 16, 2018

    

    Arnavion

    on Oct 16, 2018

    ContributorAuthor

    More actions

    A bunch of stuff changed with oli-obk's recent change so the second patch won't apply directly. I'll retest and put up a fork.
14. Arnavion commented on Oct 16, 2018

    

    Arnavion

    on Oct 16, 2018

    Last edited by Arnavion

    ContributorAuthor

    More actions

    @tikue

    For the first ICE (function that returns existential type in crate A called from crate B), the patch (on top of 46880f4) is

    diff --git a/src/librustc_resolve/build_reduced_graph.rs b/src/librustc_resolve/build_reduced_graph.rs
    index 25a7ff9cd3..02a28a1e2f 100644
    --- a/src/librustc_resolve/build_reduced_graph.rs
    +++ b/src/librustc_resolve/build_reduced_graph.rs
    @@ -736,6 +736,9 @@ impl<'a, 'cl> Resolver<'a, 'cl> {
                 Def::Macro(..) => {
                     self.define(parent, ident, MacroNS, (def, vis, DUMMY_SP, expansion));
                 }
    +            Def::Existential(..) => {
    +                self.define(parent, ident, TypeNS, (def, vis, DUMMY_SP, expansion));
    +            }
                 _ => bug!("unexpected definition: {:?}", def)
             }
         }

    The second ICE (existential type exported from crate A used as struct member in crate B) is already fixed.

    The third ICE (existential type exported from crate A used in return type of a function in crate B) still exists.

    And, while I'm at it, @andreytkachenko's ICE also still exists.
15. 2 remaining items

    Load more

16. jimmycuadra commented on Dec 13, 2018

    

    jimmycuadra

    on Dec 13, 2018

    Contributor

    More actions

    Just encountered an ICE and searching led me here. Is this just another instance of the same bug or should I report it separately?

    Run cargo test on rustin@a100f20 using nightly rustc and you get:

    error: internal compiler error: src/librustc_metadata/decoder.rs:893: cannot get associated-item of `DefKey { parent: Some(DefIndex(0:47)), disambiguated_data: DisambiguatedDefPathData { data: AssocExistentialInImpl("Success"), disambiguator: 0 } }`
    
    thread 'main' panicked at 'Box<Any>', src/librustc_errors/lib.rs:600:9
    note: Run with `RUST_BACKTRACE=1` for a backtrace.
    error: aborting due to previous error
    
17. oli-obk

    self-assigned this

    on Dec 14, 2018
18. jonhoo commented on Dec 14, 2018

    

    jonhoo

    on Dec 14, 2018

    Last edited by jonhoo

    Contributor

    More actions

    I'm running into this with noria too. Curiously, I see this when I run tests, presumably because the crate-under-test essentially operates as an "external" crate?

    ICE

    error: internal compiler error: src/librustc_metadata/decoder.rs:893: cannot get associated-item of `DefKey { parent: Some(DefIndex(0:231)), disambiguated_data: DisambiguatedDefPathData { data: AssocExistentialInImpl("Future"), disambiguator: 0 } }`
    thread 'main' panicked at 'Box', src/librustc_errors/lib.rs:600:9
    
    stack backtrace:
    
    0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
    
    at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
    
    1: std::sys_common::backtrace::_print
    
    at src/libstd/sys_common/backtrace.rs:71
    
    2: std::panicking::default_hook::{{closure}}
    
    at src/libstd/sys_common/backtrace.rs:59
    
    at src/libstd/panicking.rs:210
    
    3: std::panicking::default_hook
    
    at src/libstd/panicking.rs:224
    
    4: rustc::util::common::panic_hook
    
    5: std::panicking::rust_panic_with_hook
    
    at src/libstd/panicking.rs:491
    
    6: std::panicking::begin_panic
    
    7: rustc_errors::Handler::bug
    
    8: rustc::util::bug::opt_span_bug_fmt::{{closure}}
    
    9: rustc::ty::context::tls::with_opt::{{closure}}
    
    10: rustc::ty::context::tls::with_context_opt
    
    11: rustc::ty::context::tls::with_opt
    
    12: rustc::util::bug::opt_span_bug_fmt
    
    13: rustc::util::bug::bug_fmt
    
    14: rustc_metadata::decoder::::get_associated_item
    
    15: rustc_metadata::cstore_impl::provide_extern::associated_item
    
    16: rustc::ty::query::__query_compute::associated_item
    
    17: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors<'tcx> for rustc::ty::query::queries::associated_item<'tcx>>::compute
    
    18: rustc::ty::context::tls::with_context
    
    19: rustc::dep_graph::graph::DepGraph::with_task_impl
    
    20: <rustc::ty::query::plumbing::JobOwner<'a, 'tcx, Q>>::start
    
    21: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::force_query_with_job
    
    22: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::get_query
    
    23: rustc::traits::project::assoc_ty_def
    
    24: rustc::infer::InferCtxt::commit_if_ok
    
    25: rustc::traits::project::opt_normalize_projection_type
    
    26: rustc::traits::project::normalize_projection_type
    
    27: <rustc::traits::project::AssociatedTypeNormalizer<'a, 'b, 'gcx, 'tcx> as rustc::ty::fold::TypeFolder<'gcx, 'tcx>>::fold_ty
    
    28: rustc::traits::project::opt_normalize_projection_type
    
    29: rustc::traits::project::normalize_projection_type
    
    30: rustc::ty::context::tls::with_related_context
    
    31: rustc::infer::canonical::query_response::<impl rustc::infer::InferCtxtBuilder<'cx, 'gcx, 'tcx>>::enter_canonical_trait_query
    
    32: rustc_traits::normalize_projection_ty::normalize_projection_ty
    
    33: rustc::ty::query::__query_compute::normalize_projection_ty
    
    34: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors<'tcx> for rustc::ty::query::queries::normalize_projection_ty<'tcx>>::compute
    
    35: rustc::ty::context::tls::with_context
    
    36: rustc::dep_graph::graph::DepGraph::with_task_impl
    
    37: <rustc::ty::query::plumbing::JobOwner<'a, 'tcx, Q>>::start
    
    38: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::force_query_with_job
    
    39: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::get_query
    
    40: <rustc::traits::query::normalize::QueryNormalizer<'cx, 'gcx, 'tcx> as rustc::ty::fold::TypeFolder<'gcx, 'tcx>>::fold_ty
    
    41: <smallvec::SmallVec as core::iter::traits::FromIterator<::Item>>::from_iter
    
    42: rustc::ty::fold::TypeFoldable::fold_with
    
    43: rustc::ty::structural_impls::<impl rustc::ty::fold::TypeFoldable<'tcx> for &'tcx rustc::ty::TyS<'tcx>>::super_fold_with
    
    44: <rustc::traits::query::normalize::QueryNormalizer<'cx, 'gcx, 'tcx> as rustc::ty::fold::TypeFolder<'gcx, 'tcx>>::fold_ty
    
    45: <smallvec::SmallVec as core::iter::traits::FromIterator<::Item>>::from_iter
    
    46: rustc::ty::fold::TypeFoldable::fold_with
    
    47: rustc::ty::structural_impls::<impl rustc::ty::fold::TypeFoldable<'tcx> for &'tcx rustc::ty::TyS<'tcx>>::super_fold_with
    
    48: <rustc::traits::query::normalize::QueryNormalizer<'cx, 'gcx, 'tcx> as rustc::ty::fold::TypeFolder<'gcx, 'tcx>>::fold_ty
    
    49: <smallvec::SmallVec as core::iter::traits::FromIterator<::Item>>::from_iter
    
    50: rustc::ty::fold::TypeFoldable::fold_with
    
    51: rustc::ty::structural_impls::<impl rustc::ty::fold::TypeFoldable<'tcx> for &'tcx rustc::ty::TyS<'tcx>>::super_fold_with
    
    52: <rustc::traits::query::normalize::QueryNormalizer<'cx, 'gcx, 'tcx> as rustc::ty::fold::TypeFolder<'gcx, 'tcx>>::fold_ty
    
    53: rustc::traits::query::normalize::<impl rustc::infer::at::At<'cx, 'gcx, 'tcx>>::normalize
    
    54: rustc::ty::context::tls::with_related_context
    
    55: rustc::infer::InferCtxtBuilder::enter
    
    56: rustc_traits::normalize_erasing_regions::normalize_ty_after_erasing_regions
    
    57: rustc::ty::query::__query_compute::normalize_ty_after_erasing_regions
    
    58: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors<'tcx> for rustc::ty::query::queries::normalize_ty_after_erasing_regions<'tcx>>::compute
    
    59: rustc::ty::context::tls::with_context
    
    60: rustc::dep_graph::graph::DepGraph::with_task_impl
    
    61: <rustc::ty::query::plumbing::JobOwner<'a, 'tcx, Q>>::start
    
    62: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::force_query_with_job
    
    63: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::get_query
    
    64: <rustc::traits::query::normalize_erasing_regions::NormalizeAfterErasingRegionsFolder<'cx, 'tcx> as rustc::ty::fold::TypeFolder<'tcx, 'tcx>>::fold_ty
    
    65: rustc::traits::codegen::<impl rustc::ty::context::TyCtxt<'a, 'tcx, 'tcx>>::subst_and_normalize_erasing_regions
    
    66: <rustc_mir::monomorphize::collector::MirNeighborCollector<'a, 'tcx> as rustc::mir::visit::Visitor<'tcx>>::visit_terminator_kind
    
    67: rustc_mir::monomorphize::collector::collect_items_rec
    
    68: rustc_mir::monomorphize::collector::collect_items_rec
    
    69: rustc_mir::monomorphize::collector::collect_items_rec
    
    70: rustc_mir::monomorphize::collector::collect_items_rec
    
    71: rustc_mir::monomorphize::collector::collect_items_rec
    
    72: rustc_mir::monomorphize::collector::collect_items_rec
    
    73: rustc_mir::monomorphize::collector::collect_items_rec
    
    74: rustc_mir::monomorphize::collector::collect_items_rec
    
    75: rustc_mir::monomorphize::collector::collect_items_rec
    
    76: rustc_mir::monomorphize::collector::collect_items_rec
    
    77: rustc_mir::monomorphize::collector::collect_items_rec
    
    78: rustc_mir::monomorphize::collector::collect_items_rec
    
    79: rustc_mir::monomorphize::collector::collect_items_rec
    
    80: rustc_mir::monomorphize::collector::collect_items_rec
    
    81: rustc_mir::monomorphize::collector::collect_items_rec
    
    82: rustc_mir::monomorphize::collector::collect_items_rec
    
    83: rustc_mir::monomorphize::collector::collect_items_rec
    
    84: rustc_mir::monomorphize::collector::collect_items_rec
    
    85: rustc_mir::monomorphize::collector::collect_crate_mono_items::{{closure}}
    
    86: rustc::util::common::time
    
    87: rustc_mir::monomorphize::collector::collect_crate_mono_items
    
    88: rustc::util::common::time
    
    89: rustc_mir::monomorphize::partitioning::collect_and_partition_mono_items
    
    90: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors<'tcx> for rustc::ty::query::queries::collect_and_partition_mono_items<'tcx>>::compute
    
    91: rustc::ty::context::tls::with_context
    
    92: rustc::dep_graph::graph::DepGraph::with_task_impl
    
    93: <rustc::ty::query::plumbing::JobOwner<'a, 'tcx, Q>>::start
    
    94: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::force_query_with_job
    
    95: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt<'a, 'gcx, 'tcx>>::get_query
    
    96: rustc_codegen_ssa::base::codegen_crate
    
    97: <rustc_codegen_llvm::LlvmCodegenBackend as rustc_codegen_utils::codegen_backend::CodegenBackend>::codegen_crate
    
    98: rustc::util::common::time
    
    99: rustc_driver::driver::phase_4_codegen
    
    query stack during panic:
    
    #0 [associated_item] processing <noria::table::Table as tower_service::Service<noria::table::Input>>::Future
    
    #1 [normalize_projection_ty] normalizing Canonical { max_universe: U0, variables: [], value: ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: ProjectionTy { substs: [noria::table::Table, std::vec::Vec<noria::data::TableOperation>], item_def_id: DefId(97/0:10 ~ tower_service[c637]::Service[0]::Future[0]) } } }
    
    #2 [normalize_ty_after_erasing_regions] normalizing ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: fn(tower_util::ext::ready::Ready<noria::table::Table, std::vec::Vec<noria::data::TableOperation>>, [closure@DefId(91/1:105 ~ noria[413f]::table[0]::{{impl}}[7]::quick_n_dirty[0]::{{closure}}[0]) 0:std::vec::Vec<noria::data::TableOperation>]) -> futures::future::and_then::AndThen<tower_util::ext::ready::Ready<noria::table::Table, std::vec::Vec<noria::data::TableOperation>>, <noria::table::Table as tower_service::Service<std::vec::Vec<noria::data::TableOperation>>>::Future, [closure@DefId(91/1:105 ~ noria[413f]::table[0]::{{impl}}[7]::quick_n_dirty[0]::{{closure}}[0]) 0:std::vec::Vec<noria::data::TableOperation>]> {<tower_util::ext::ready::Ready<noria::table::Table, std::vec::Vec<noria::data::TableOperation>> as futures::future::Future>::and_then::<[closure@DefId(91/1:105 ~ noria[413f]::table[0]::{{impl}}[7]::quick_n_dirty[0]::{{closure}}[0]) 0:std::vec::Vec<noria::data::TableOperation>], <noria::table::Table as tower_service::Service<std::vec::Vec<noria::data::TableOperation>>>::Future>} }
    
    #3 [collect_and_partition_mono_items] collect_and_partition_mono_items
    
    end of query stack
19. Arnavion commented on Dec 20, 2018

    

    Arnavion

    on Dec 20, 2018

    ContributorAuthor

    More actions

    @jonhoo Yes. If you see the "Easy playground repro" link in the OP, that happens because the doctest is a separate crate.
20. alecmocatta

    added 2 commits that reference this issue on Jan 11, 2019

    ICE rust-lang/rust#53443

    2a813dc

    ICE rust-lang/rust#53443

    41896b5
21. jonhoo

    added a commit that references this issue on Jan 11, 2019

    And now work around rust-lang/rust#53443

    34620e6
22. jonhoo commented on Jan 21, 2019

    

    jonhoo

    on Jan 21, 2019

    Contributor

    More actions

    @oli-obk any thoughts on the further ICEs that @Arnavion discovered when trying to fix this? This ICE sadly makes existential types pretty unusable in libraries.
23. jonhoo

    added a commit that references this issue on Jan 21, 2019

    Steps needed to remove boxing from view/table ops

    ...

    fa2699e
24. oli-obk commented on Jan 22, 2019

    

    oli-obk

    on Jan 22, 2019

    Contributor

    More actions

    Sorry about taking so long, it was just a few small fixes in the end. I think #57836 fixes all the ICEs mentioned in this issue.

    🎉React with 🎉1Reacted by Jon Gjengset

    ❤️React with ❤️1Reacted by Jon Gjengset
25. Centril

    added a commit that references this issue on Jan 23, 2019

    Rollup merge of rust-lang#57836 - oli-obk:existential_crisis, r=estebank

    ...

    This issue will close once commit d17f62d is merged into the 'master' branch.

    d17f62d
26. bors

    closed this as completedin d17f62don Jan 24, 2019
27. Arnavion commented on Jan 24, 2019

    

    Arnavion

    on Jan 24, 2019

    ContributorAuthor

    More actions

    Thanks. I confirmed this fixed all the issues with my original project too.

    🎉React with 🎉1Reacted by Jon Gjengset

    ❤️React with ❤️1Reacted by Jon Gjengset
28. jonhoo

    added a commit that references this issue on Jan 27, 2019

    Steps needed to remove boxing from view/table ops

    ...

    4e3846e
29. andreytkachenko commented on Jan 29, 2019

    

    andreytkachenko

    on Jan 29, 2019

    Contributor

    More actions

    @oli-obk could you also take a look at #53598, I suppose it is very close to that one. Thank you.