Skip to content

[nll] use NLL during bootstrapping #53172

Closed
Closed
[nll] use NLL during bootstrapping#53172
Labels
A-NLLArea: Non-lexical lifetimes (NLL)NLL-completeWorking towards the "valid code works" goalT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Rust 2018 RC

Description

@nikomatsakis
nikomatsakis
opened on Aug 7, 2018

An important correctness milestone is to have the compiler itself use NLL when bootstrapping. We've made some stabs at this but we need to start doing it all the time.

Instructions

  • Log into Zulip and head to correct thread to say hi =)
  • Select a crate from the list below
  • Leave a comment that you are trying it
  • Verify that ./x.py build --stage 1 works for you
  • Add #![cfg_attr(not(stage0), feature(nll))] to the lib.rs file
    • This incantation adds #![feature(nll)], but only once we get to stage1 -- otherwise we'd be using the beta version of NLL, which is old and buggy.)
  • Try ./x.py build --stage 1 again and see if it works
  • If so, open a PR

Crate list

Activity

  1. nikomatsakis
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    A-NLLArea: Non-lexical lifetimes (NLL)
    WG-compiler-nll
    NLL-completeWorking towards the "valid code works" goal
    on Aug 7, 2018
  2. nikomatsakis
    added this to the Rust 2018 RC milestone on Aug 7, 2018
  3. nikomatsakis
    added
    I-nominated
    on Aug 7, 2018

  4. lovesegfault commented on Aug 7, 2018

    @lovesegfault
    lovesegfault
    on Aug 7, 2018
    Contributor

    I'm going to be attempting this for librustc_mir just to start.

  5. nikomatsakis
    added
    I-nominated
    and removed
    I-nominated
    on Aug 9, 2018
  6. kennytm
    added 6 commits that reference this issue on Aug 9, 2018

    Rollup merge of rust-lang#53211 - memoryruins:nll_bootstrap, r=nikoma…

    bb0151c

    Rollup merge of rust-lang#53214 - memoryruins:nll_bootstrap_2, r=niko…

    62d70c9

    Rollup merge of rust-lang#53219 - memoryruins:nll_bootstrap_3, r=niko…

    e2d0e3f

    Rollup merge of rust-lang#53230 - memoryruins:nll_bootstrap_4, r=niko…

    1bd57e2
  7. GuillaumeGomez
    added a commit that references this issue on Aug 12, 2018

    Rollup merge of rust-lang#53230 - memoryruins:nll_bootstrap_4, r=niko…

    3e9a1a1

  8. pnkfelix commented on Aug 14, 2018

    @pnkfelix
    pnkfelix
    on Aug 14, 2018
    Contributor

    The remaining four crates:

    • liblibc
    • libbacktrace
    • libcompiler_builtins
    • stdsimd

    are all "external dependencies", in the sense that they are crates that have been factored out and are hosted on separate repositories (still within the rust-lang or rust-lang-nursery ecosystems).

    So, it seems like the vast majority of work here is done, and the important thing is: It seems clear that we can bootstrap ourselves using NLL.

    Therefore, I am closing this task as "effectively finished"

  9. pnkfelix
    closed this as completedon Aug 14, 2018

  10. memoryruins commented on Aug 14, 2018

    @memoryruins
    memoryruins
    on Aug 14, 2018
    Contributor

    Note: locally, libcompiler_builtins successfully built with NLL. I expect stdsimd and any others would too.

    Well done, everyone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-NLLArea: Non-lexical lifetimes (NLL)NLL-completeWorking towards the "valid code works" goalT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions