Repository navigation
Procedural macro crates should require at most one definition per macro name #52225
Description
Discovered by @alercah here, this crate should be rejected:
#![crate_type = "proc-macro"]
extern crate proc_macro;
use proc_macro::TokenStream;
#[proc_macro]
pub fn bad(_ : TokenStream) -> TokenStream { "".parse().unwrap() }
#[proc_macro_derive(bad)]
pub fn deriver(_ : TokenStream) -> TokenStream { "".parse().unwrap() }
Activity
alexcrichton commentedon Jul 10, 2018
I believe this would be fixed by @petrochenkov suggestion here where definition of a macro inserts an entry into the macro namespace, although @petrochenkov correct me if I'm wrong!
petrochenkov commentedon Jul 10, 2018
The issue solvable by inserting a dummy entry into macro namespace is not about inert attributes in derives, but about this case.
petrochenkov commentedon Jul 10, 2018
Stabilization PR for proc macro definitions is in process of merge (#52081), so this should be fixed soon too.
petrochenkov commentedon Jul 12, 2018
Fixed locally, will submit a PR today.
Auto merge of #52383 - petrochenkov:pmns, r=alexcrichton