Skip to content

[tracking issue] const fn std::mem::needs_drop #51929

Closed
#60364
#54596
Closed
[tracking issue] const fn std::mem::needs_drop#51929
#60364
#54596
Labels
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-langRelevant to the language teamT-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

Description

@Havvy
Havvy
opened on Jun 30, 2018

The issue title says it all really. std::mem::needs_drop is a function that doesn't change from call to call once monomorphized, so it should be a const function.

EDIT:

This has been implemented and it is waiting for stabilization now.

Activity

  1. stokhos
    added
    A-collectionsArea: `std::collections`
    on Jun 30, 2018
  2. retep998
    added
    A-const-fn
    A-destructorsArea: Destructors (`Drop`, …)
    on Jun 30, 2018
  3. oli-obk
    added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on Jun 30, 2018

  4. oli-obk commented on Jun 30, 2018

    @oli-obk
    oli-obk
    on Jun 30, 2018
    Contributor

    blocked on #51570

  5. oli-obk
    added
    S-blockedStatus: Blocked on something else such as an RFC or other implementation work.
    on Jun 30, 2018

  6. JoshBrudnak commented on Aug 18, 2018

    @JoshBrudnak
    JoshBrudnak
    on Aug 18, 2018
    Contributor

    @oli-obk is this still blocked? If not I would like to help out with it. 👍

  7. oli-obk commented on Aug 20, 2018

    @oli-obk
    oli-obk
    on Aug 20, 2018
    Contributor

    Should be fine to add behind a feature gate.

    The steps are basically the same as #51171 and #51299 (but you can do them in a single PR)

  8. JoshBrudnak
    added a commit that references this issue on Aug 25, 2018

    Make std::mem::needs_drop a const fn rust-lang#51929

    d06266f
  9. bors
    closed this as completedin #54596on Sep 30, 2018

  10. mjbshaw commented on Oct 1, 2018

    @mjbshaw
    mjbshaw
    on Oct 1, 2018
    Contributor

    It might be nice to keeps this issue open until const_needs_drop is stabilized.

  11. oli-obk
    reopened this on Oct 1, 2018
  12. oli-obk
    changed the title [-]std::mem::needs_drop should be a const fn[/-] [+][tracking issue] const fn std::mem::needs_drop[/+] on Oct 1, 2018

  13. 12 remaining items

  14. rfcbot commented on Jan 23, 2019

    @rfcbot
    rfcbot
    on Jan 23, 2019

    Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

    No concerns currently listed.

    Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  15. rfcbot
    added
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.
    on Jan 23, 2019

  16. Centril commented on Jan 24, 2019

    @Centril
    Centril
    on Jan 24, 2019
    Contributor

    Seems unobjectionable (assuming the implementation is up to snuff...? cc @oli-obk).

  17. Centril
    removed
    I-nominated
    on Jan 24, 2019

  18. oli-obk commented on Jan 24, 2019

    @oli-obk
    oli-obk
    on Jan 24, 2019
    Contributor

    Yea, the impl has baked in miri since long before it was in const eval. I also rechecked it and I see no reason not to stabilize.

  19. Centril commented on Mar 9, 2019

    @Centril
    Centril
    on Mar 9, 2019
    Contributor

    👋 @joshtriplett @nikomatsakis @pnkfelix @withoutboats

  20. rfcbot commented on Mar 29, 2019

    @rfcbot
    rfcbot
    on Mar 29, 2019

    🔔 This is now entering its final comment period, as per the review above. 🔔

  21. rfcbot
    added
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    and removed
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Mar 29, 2019

  22. rfcbot commented on Apr 8, 2019

    @rfcbot
    rfcbot
    on Apr 8, 2019

    The final comment period, with a disposition to merge, as per the review above, is now complete.

    As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

    The RFC will be merged soon.

  23. rfcbot
    added
    finished-final-comment-periodThe final comment period is finished for this PR / Issue.
    and removed
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Apr 8, 2019
  24. bors
    added a commit that references this issue on Apr 29, 2019

    Auto merge of #60364 - JohnTitor:stabilize-const-needs-drop, r=oli-obk

    00acb7b
  25. bors
    closed this as completedin #60364on Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-langRelevant to the language teamT-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions