Compiler suggests using the removed placement syntax

So I'm writing a hangman app in Rust and I get this weird error message. It doesn't make sense since <- isn't even in Rust anymore.

error: expected `{`, found `in`
  --> src/main.rs:8:17
   |
8  |           if line in words {
   |  _________________-^
9  | |             println!("Success");
10 | |         } else {
   | |_________- help: try placing this code inside a block: `{ words <- { println!("Success"); }; }`

error: aborting due to previous error

error: Could not compile `hangman`.

Could we just stop parsing in «expr» «block» as an ObsoleteInPlace expression? Will it break any macros or code behind #[cfg]?

Yeah #50832.

#50832 was about x <- y though

I think the same issue applies though - the parser still needs to be able to recognise the code as something. So if there are crates using that syntax, they'll break in the same way.

Current output:

error: expected `{`, found `in`
 --> src/main.rs:2:10
  |
2 |       if i in 0..10 {
  |       --   -^
  |  _____|____|
  | |     |
  | |     this `if` statement has a condition, but no block
3 | |         break;
4 | |     }
  | |_____- help: try placing this code inside a block: `{ (0..10) <- { break ; }; }`

Still need to remove the suggestion, but otherwise the error would seem reasonable:

error: expected `{`, found `in`
 --> src/main.rs:2:10
  |
2 |     if i in 0..10 {
  |     --   ^^ expected `{`
  |     |
  |     this `if` statement has a condition, but no block

@estebank

@estebank should this be done only for in keyword or you also have other statements in mind.

@PramodBisht

@PramodBisht I believe that in and type ascription (:) are the only two that regularly cause problems with this kind of errors.

Rollup merge of rust-lang#53360 - PramodBisht:issue/51602, r=estebank

Auto merge of #53433 - kennytm:rollup, r=kennytm

Navigation Menu

Repository navigation

Compiler suggests using the removed placement syntax #51602

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Compiler suggests using the removed placement syntax #51602

Description

Activity

kennytm commented on Jun 18, 2018

emilyalbini commented on Jun 18, 2018

kennytm commented on Jun 18, 2018

aidanhs commented on Jun 22, 2018

estebank commented on Aug 8, 2018

PramodBisht commented on Aug 11, 2018

estebank commented on Aug 11, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions