Skip to content

Make ./x.py errors more machine-grep-able #51385

Closed

Description

@mark-i-m

We should systematically make all errors emitted by ./x.py more grep-able. This will make life easier for @TimNN and other bots.

Activity

  1. Mark-Simulacrum commented on Jun 6, 2018

    @Mark-Simulacrum
    Member

    Could you be more specific? What do you mean by "errors emitted by x.py"? Most of these are test failures and compiler failures... which are already quite good, generally speaking, I'd imagine.

  2. mark-i-m commented on Jun 6, 2018

    @mark-i-m
    ContributorAuthor

    Yes, I mostly mean compile and test failures -- anything that would fail a Travis build. Surprisingly, these are not as easy to find as one might expect, since TimNNBot often gives not-very-helpful snippets (e.g. too much or too little, such as #51335 (comment)).

    Instead we should print something like "[ERROR START]" and "[ERROR END]" around the portions we want bots to pick up.

  3. Mark-Simulacrum commented on Jun 6, 2018

    @Mark-Simulacrum
    Member

    The bot isn't based on start/stop lines iirc, so I'm not sure that's the right approach. @TimNN probably knows better than me, though.

  4. hellow554 commented on Jun 6, 2018

    @hellow554
    Contributor

    One way could be --output-format=json|xml|....
    I mean, the effort to do this is quite high, but you have to decide if it's worth it.

  5. added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    C-feature-requestCategory: A feature request, i.e: not implemented / a PR.
    on Sep 15, 2018
  6. mark-i-m commented on Apr 3, 2019

    @mark-i-m
    ContributorAuthor

    There doesn't seem to be high demand for this. Shall I close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-feature-requestCategory: A feature request, i.e: not implemented / a PR.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions