Skip to content

compiletest: check_no_compiler_crash doesn't catch non-ICE panics #49888

Closed
Closed
compiletest: check_no_compiler_crash doesn't catch non-ICE panics#49888
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@cuviper
cuviper
opened on Apr 11, 2018

As noted in #49826 (comment), currently rustc is panicking on compile-fail/issue-36638 (which I will file as a separate bug), but compiletest does not detect this because it's also not caught as an ICE (to be fixed by #49826). In check_no_compiler_crash, it only looks for the literal string "error: internal compiler error".

Activity

  1. cuviper
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    C-bugCategory: This is a bug.
    on Apr 11, 2018
  2. bors
    added a commit that references this issue on Apr 27, 2018

    Auto merge of #49891 - cuviper:compiletest-crash, r=alexcrichton

    9822b57
  3. bors
    closed this as completedin #49891on Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions