Skip to content

Tracking issue for str::split_ascii_whitespace #48656

Closed
#58047
Closed
Tracking issue for str::split_ascii_whitespace#48656
#58047
Labels
A-iteratorsArea: IteratorsC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

Description

@clarfonthey
clarfonthey
opened on Mar 2, 2018

Implemented in #49987:

impl str {
    pub fn split_ascii_whitespace(&self) -> SplitAsciiWhitespace {…}
}

#[derive(Clone, Debug)]
pub struct SplitAsciiWhitespace<'a> {…}

impl<'a> Iterator for SplitAsciiWhitespace<'a> {
    type Item = &'a str;
    …
}
impl<'a> DoubleEndedIterator for SplitAsciiWhitespace<'a> {…}
impl<'a> FusedIterator for SplitAsciiWhitespace<'a> {}

Original feature request:

Considering how is_ascii_whitespace is now available on libcore, it makes sense to provide this too.

I'll provide a PR at some point if this seems reasonable; a lot of code that needs to split on whitespace only needs to split on ASCII whitespace, which is considerably faster.

Activity

frewsxcv
added
T-libs-api[DEPRECATED; DO NOT USE]
on Mar 2, 2018
XAMPPRocky
added
C-feature-requestCategory: A feature request, i.e: not implemented / a PR.
on May 21, 2018
SimonSapin
added
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
A-iteratorsArea: Iterators
and removed
C-feature-requestCategory: A feature request, i.e: not implemented / a PR.
on Jun 27, 2018
SimonSapin
changed the title [-]str::split_ascii_whitespace[/-] [+]Tracking isuse for str::split_ascii_whitespace[/+] on Jun 27, 2018
SimonSapin
changed the title [-]Tracking isuse for str::split_ascii_whitespace[/-] [+]Tracking issue for str::split_ascii_whitespace[/+] on Jun 27, 2018

SimonSapin commented on Jun 27, 2018

@SimonSapin
SimonSapin
on Jun 27, 2018
Contributor

The implementation PR is in the bors queue, I’ve turned this into a tracking issue.

kennytm
added a commit that references this issue on Jun 27, 2018

Rollup merge of rust-lang#49987 - clarcharr:split_ascii_whitespace, r…

e5462b8

clarfonthey commented on Nov 27, 2018

@clarfonthey
clarfonthey
on Nov 27, 2018
ContributorAuthor

How do people feel about stabilising this?

SimonSapin commented on Nov 28, 2018

@SimonSapin
SimonSapin
on Nov 28, 2018
Contributor

Let’s.

@rfcbot fcp merge

rfcbot commented on Nov 28, 2018

@rfcbot
rfcbot
on Nov 28, 2018

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot
added
proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.
final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
on Nov 28, 2018

rfcbot commented on Nov 29, 2018

@rfcbot
rfcbot
on Nov 29, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot
removed
proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
on Nov 29, 2018

rfcbot commented on Dec 9, 2018

@rfcbot
rfcbot
on Dec 9, 2018

The final comment period, with a disposition to merge, as per the review above, is now complete.

rfcbot
added
finished-final-comment-periodThe final comment period is finished for this PR / Issue.
and removed
final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
on Dec 9, 2018

Centril commented on Dec 29, 2018

@Centril
Centril
on Dec 29, 2018
Contributor

@clarcharr Up for writing a stabilization PR?

SimonSapin
added a commit that references this issue on Feb 1, 2019

Stabilize split_ascii_whitespace

6a01f8a
bors
closed this as completedin #58047on Feb 2, 2019
asettouf
added 4 commits that reference this issue on Feb 26, 2019

Changing error message to reflect changes with the 2018 edition

2e5eb11

Changing error message to reflect changes with the 2018 edition

7bd907f

Changing error message to reflect changes with the 2018 edition

c1f3d15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-iteratorsArea: IteratorsC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions