Skip to content

rustdoc: integrate a proper warning/error handler #46844

Closed
Closed
rustdoc: integrate a proper warning/error handler#46844
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Description

@QuietMisdreavus
QuietMisdreavus
opened on Dec 19, 2017

The current markdown rendering warnings are just a collection of println!() statements. It would be worthwhile to create a rustc_errors::Handler for rustdoc to properly emit errors from, so that these and others can be given proper formatting, and possibly even a mini lint system, or at least being able toggle specific errors between allow/warn/err.

Activity

  1. QuietMisdreavus
    added
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    on Dec 19, 2017

  2. euclio commented on Feb 13, 2019

    @euclio
    euclio
    on Feb 13, 2019
    Contributor

    I think this is fixed, no?

  3. QuietMisdreavus commented on Feb 14, 2019

    @QuietMisdreavus
    QuietMisdreavus
    on Feb 14, 2019
    ContributorAuthor

    Indeed it is! We've started using a diagnostic emitter from rustc_errors, and all our errors and warnings go through that mechanism now. I'll close this.

  4. QuietMisdreavus
    closed this as completedon Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions