Skip to content

Remove structural records from libcore, libstd, macros #4665

Closed

Description

@catamorphism

libcore has structural records removed for the most part (thanks to @erickt 's heroic work!) but a few modules still have it enabled because the pipes code generates code with structural records. I'm a little afraid to fix the pipes compiler (I'm not sure how to make it generate new names for struct types), but could with some help.

The extfmt code also needs to be changed to not generate structural records.

Finally (for now), libstd needs to have records removed as well.

Activity

  1. erickt commented on Jan 29, 2013

    @erickt
    Contributor

    I already landed my extfmt and pipes patches, and most of libstd has been converted too. I'm just waiting on a snapshot to remove my #[cfg(stage...)] blocks.

  2. catamorphism commented on Jan 29, 2013

    @catamorphism
    ContributorAuthor

    @erickt Great, thanks! Sorry, I must have read your patches hastily and didn't notice that you also fixed extfmt and pipes :-)

  3. catamorphism commented on Jan 29, 2013

    @catamorphism
    ContributorAuthor

    I have a new snapshot ready that should work for this; currently running try.

  4. catamorphism commented on Feb 4, 2013

    @catamorphism
    ContributorAuthor

    I've de-recorded libstd and am just running tests. I also have a snapshot branch that should build, but is not compiling on the Mac and Linux bots (I'm investigating).

  5. added a commit that references this issue on Feb 5, 2013
  6. added a commit that references this issue on Feb 5, 2013
  7. catamorphism commented on Feb 7, 2013

    @catamorphism
    ContributorAuthor

    I forgot to remove one use of structural records from the pipes compiler ( gen_buffer_init in libsyntax/ext/pipec.rs). >:-(

  8. catamorphism commented on Feb 19, 2013

    @catamorphism
    ContributorAuthor

    I'll try to finish this now that df4273f is in. Specifically I'll start a snapshot building.

  9. catamorphism commented on Feb 19, 2013

    @catamorphism
    ContributorAuthor

    Snapshot is now building.

  10. bstrie commented on Mar 7, 2013

    @bstrie
    Contributor

    I think this can be closed now.

  11. nikomatsakis commented on Mar 25, 2013

    @nikomatsakis
    Contributor

    Records appear to be completely removed from compiler

  12. removed their assignment
    on Jun 16, 2014
  13. added a commit that references this issue on Nov 8, 2025
  14. added a commit that references this issue on Aug 21, 2026
    1a82af3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-syntaxextArea: Syntax extensionsC-cleanupCategory: PRs that clean code up or issues documenting cleanup.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions