Skip to content

rustdoc nightly: search deduplication can cause missing items #45968

Closed

Description

@crumblingstatue

This example is outdated, but in it, thread::spawn is missing in nightly.

stable:

nightly:

Probably caused by ee7e372.

Activity

  1. added
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    on Nov 13, 2017
  2. crumblingstatue commented on Nov 15, 2017

    @crumblingstatue
    ContributorAuthor

    This seems fixed on (ff0f5de3b 2017-11-14), but I don't know if a regression test should be added or something, so I'll leave this open for now.

    EDIT: It's not fixed, see comment below.

  3. added
    E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.
    and removed on Nov 15, 2017
  4. ollie27 commented on Nov 16, 2017

    @ollie27
    Contributor

    This isn't fixed. Now std::thread::Builder::spawn is missing. I believe this was originally caused by ee7e372 (cc @GuillaumeGomez). It seems to be de-duplicating search results based on path + name ignoring parent and ty so it's treating std::thread::spawn and std::thread::Builder::spawn as the same.

  5. added and removed
    E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.
    on Nov 16, 2017
  6. changed the title [-]rustdoc nightly: thread::spawn not shown when searching for `spawn`[/-] [+]rustdoc nightly: deduplication can cause missing items[/+] on Nov 16, 2017
  7. changed the title [-]rustdoc nightly: deduplication can cause missing items[/-] [+]rustdoc nightly: search deduplication can cause missing items[/+] on Nov 16, 2017
  8. GuillaumeGomez commented on Nov 24, 2017

    @GuillaumeGomez
    Member

    I have to wait for both of my rustdoc PRs here and here) to be merged before looking for this.

  9. durka commented on Nov 28, 2017

    @durka
    Contributor

    Searching for read_to_end in the nightly docs doesn't come up with std::io::Read::read_to_end. Is this the same issue?

  10. GuillaumeGomez commented on Nov 29, 2017

    @GuillaumeGomez
    Member

    Maybe? I'll take a look as well.

  11. GuillaumeGomez commented on Dec 1, 2017

    @GuillaumeGomez
    Member

    Can you confirm once again? When I just tested on nightly, it worked as expected?

  12. GuillaumeGomez commented on Dec 1, 2017

    @GuillaumeGomez
    Member

    @durka: However, your issue is still there. Taking a look.

  13. added a commit that references this issue on Dec 3, 2017
    d0ebb4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

C-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions