Skip to content

operand types are not normalized in MIR shims #45940

Description

@nikomatsakis

In normal MIR, the types of local variables and things are fully normalized. However, in the MIR shims we construct, this is not always the case. We encountered this when fixing #45889, where it is necessary to normalize the types of operands in some cases to make the existing MIR typeck.

I'm not sure if this is a bug per se. Certainly once we move to lazy norm it will be fine. =) But it was surprising. For now we are normalizing (in the case of ADT constructors) during typeck.

cc @arielb1

Activity

  1. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Nov 12, 2017
  2. nikomatsakis commented on Nov 12, 2017

    @nikomatsakis
    ContributorAuthor
  3. added this to the NLL prototype milestone on Nov 15, 2017
  4. nikomatsakis commented on Nov 16, 2017

    @nikomatsakis
    ContributorAuthor

    I don't think this belongs in the milestone. This isn't really a problem, it's just causing us to run some extra normalizations -- or normalizations at an unexpected time.

  5. removed this from the NLL prototype milestone on Nov 16, 2017
  6. added a commit that references this issue on Nov 26, 2017
    1be38e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions