Skip to content

install.sh in distribution tarballs does not preserve executable bit #44594

Description

@RalfJung

Steps to reproduce:

  • ./x.py dist
  • cd $SOMEWHERE
  • tar -xzvf $RUSTC/build/dist/rust-src-1.22.0-dev.tar.gz
  • ls -lah rust-src-1.22.dev/rust-src/lib/rustlib/src/rust/src/jemalloc/include/jemalloc/
    Observe how some files here are executable.
  • mkdir foo && ./install.sh --prefix=foo
  • ls -lah foo/lib/rustlib/src/rust/src/jemalloc/include/jemalloc/

Expected behavior

The same files should be executable.

Actual behavior

No file is executable.

It seems rustup blissfully ignores the installer scripts here anyway, because rustup does preserve executable bits. This makes me wonder what the point of these scripts is, anyway...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions