Repository navigation
Consider adding a from_micros for std::time::Duration #44400
Description
Activity
The fix seems pretty easy, maybe if you judge this useful I can try to write my first pull request to the Rust project!
In general, this is how @rust-lang/libs works; small additions can just be a PR, larger additions need an RFC. So, I'd suggest that you send in a PR implementing this.
Adding
from_microssounds okay to me.Yeah, I'd be on board with a PR.
- addedC-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.
on Sep 17, 2017 - added a commit that references this issue
on Sep 23, 2017 This is now a tracking issue for the function added in the previously referenced PR.
- addedB-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCand removedC-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.
on Sep 27, 2017 Looks good to me to stabilize.
@rfcbot fcp merge
Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:
No concerns currently listed.
Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
- addedproposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.
on Mar 17, 2018 🔔 This is now entering its final comment period, as per the review above. 🔔
- removedproposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
on Mar 19, 2018 The final comment period is now complete.
- added a commit that references this issue
on Apr 18, 2018
During the write of an embedded library I needed to make a pause of 10 microseconds. Looking over the Nightly
std::time::Durationdocumentation page I understood that I had to use the following construction:The sad part is that this is less clear to me than
Duration::from_micros(10). Currently thefrom_millisandfrom_secsfunctions are implemented but notfrom_microswhich could help write cleaner code IMO.The fix seems pretty easy, maybe if you judge this useful I can try to write my first pull request to the Rust project!