Skip to content

Collector in trans is private #44334

Closed
Closed
Collector in trans is private#44334
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@MaikKlein
MaikKlein
opened on Sep 5, 2017

I am currently trying to create a SPIR-V backend but I am running into a few problems.

For example https://github.com/rust-lang/rust/blob/master/src/librustc_trans/collector.rs is private https://github.com/rust-lang/rust/blob/master/src/librustc_trans/lib.rs#L108

It seems that a lot of useful functionality is inside collector.rs. Would it be possible to make some functionality public? I would be happy to provide a PR.

Activity

  1. eddyb commented on Sep 6, 2017

    @eddyb
    eddyb
    on Sep 6, 2017
    Contributor

    It should be moved to to librustc_mir. cc @nikomatsakis @michaelwoerister

  2. michaelwoerister commented on Sep 6, 2017

    @michaelwoerister
    michaelwoerister
    on Sep 6, 2017
    Member

    I think we'll need to turn it into a query soon anyway.

  3. eddyb commented on Sep 6, 2017

    @eddyb
    eddyb
    on Sep 6, 2017
    Contributor

    That doesn't help, IMO. It should be a reusable piece of code. librustc_trans is the LLVM backend and therefore non-reusable.

  4. TimNN
    added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Sep 17, 2017

  5. MaikKlein commented on Oct 14, 2017

    @MaikKlein
    MaikKlein
    on Oct 14, 2017
    ContributorAuthor

    I talked with eddyb on irc about this issue.

    • moving the collector to src/librustc_mir/monomorphize/collector.rs
    • changing terminology from "trans collector" to "monomorphization collector"

    I am happy to do a PR myself.

  6. MaikKlein commented on Dec 19, 2017

    @MaikKlein
    MaikKlein
    on Dec 19, 2017
    ContributorAuthor

    Resolved by #45525

  7. MaikKlein
    closed this as completedon Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions