Repository navigation
num-traits-0.1.39 beta regression #43674
Description
num-traits version 0.1.39 regressed from stable to beta (full log):
Aug 03 12:25:49.119 INFO blam! ---- src/float.rs - float::Float::is_sign_negative (line 348) stdout ----
Aug 03 12:25:49.119 INFO blam! thread 'rustc' panicked at 'test executable failed:
Aug 03 12:25:49.119 INFO blam!
Aug 03 12:25:49.119 INFO blam! thread 'main' panicked at 'assertion failed: !nan.is_sign_positive() && !nan.is_sign_negative()', <anon>:14:0
Activity
arielb1 commentedon Aug 5, 2017
This has been fixed in 0.1.40.
alexcrichton commentedon Aug 5, 2017
@arielb1 you tagged this T-compiler but this seems more T-libs to mean, so I'm gonna switch it over (but please correct me if I'm wrong!)
cuviper commentedon Aug 5, 2017
numjust forwards tostdbehavior, but had a test that assumed the old behavior with NaN. If that change in behavior is still deemed desirable, then I think it's fine for num.est31 commentedon Aug 5, 2017
I think it is deemed desirable cc @nagisa
nagisa commentedon Aug 5, 2017
Making new methods and deprecating these was considered and decided to be not worth it, so IME it is still intentional breakage.
alexcrichton commentedon Aug 22, 2017
The libs team decided today that this is "accepted breakage", so I'm going to close