Repository navigation
direct-0.1.0 beta regression #43665
Description
direct version 0.1.0 regressed from stable to beta (full log):
error: use of unstable library feature 'ord_max_min' (see issue #25663)
--> src/lib.rs:308:54
|
308 | (ordered_float::NotNaN::new(left.min(right.into_inner())).unwrap(), idx)
| ^^^
error[E0308]: mismatched types
--> src/lib.rs:308:58
|
308 | (ordered_float::NotNaN::new(left.min(right.into_inner())).unwrap(), idx)
| ^^^^^^^^^^^^^^^^^^ expected struct `ordered_float::NotNaN`, found f64
|
= note: expected type `ordered_float::NotNaN<f64>`
found type `f64`
cc @Blei
Activity
arielb1 commentedon Aug 5, 2017
Ord::minwas added.The new
Ord::minshadowsf64'smin, which was accessed through theDerefimpl at https://github.com/reem/rust-ordered-float/blob/b27bbd4/src/lib.rs#L225.The new impl is actually more of what you want - it would allow the code to be simplified to
left.min(right). Unfortunately, that won't work on stable. But you can still usecmp::min(left, right)instead of that complicated line (after ause std::cmp;).Blei commentedon Aug 7, 2017
Thank you! Fixed and published a new version.
est31 commentedon Aug 7, 2017
Thanks!