if clauses following an if let are compiled to match guards

is this code:

struct Foo;

impl Foo {
    fn bar(&mut self) -> bool { true }
}

fn error(foo: &mut Foo) {
    if let Some(_) = Some(true) {
    } else if foo.bar() {}
}

fn ok(foo: &mut Foo) {
    if let Some(_) = Some(true) {
    } else {
        if foo.bar() {}
    }
}

fn main() {}

yielding:

rustc 1.16.0 (30cf806ef 2017-03-10)
error[E0301]: cannot mutably borrow in a pattern guard
 --> <anon>:9:15
  |
9 |     } else if foo.bar() {}
  |               ^^^ borrowed mutably in pattern guard

Where this happens. I don't know why we do this, the "else" part of "if" or "if-let" is an arbitrary expression:

if let pat = expr1 {...} else expr2
// can be lowered to
match expr1 {
    pat => {...}
    _ => expr2
}

This seems simpler, less error prone and it won't hit arbitrary limitations specific to match guards.

The RFC states:

Optionally, one or more else if (not else if let) blocks can be placed in the same match using pattern guards on _. This could be done to simplify the code when pretty-printing the expansion result. Otherwise, this is an unnecessary transformation.

This doesn't feel like a compelling reason, particularly since the desugaring is not otherwise user visible. I would call this a bug.

triage: P-medium

@eddyb

This is a great mentoring bug! I'm going to write up some very quick pointers for now. Please reach out for more details. In short, the code that needs to be changed is in the "HIR lowering", which converts from the AST (what the user wrote) to the compiler's internal HIR (also an abstract syntax tree, but somewhat desugared). The code in question is in lowering.rs, specifically right around here. There is also some more logic. You'll want to change how it is desugaring along the lines that @eddyb suggested in this comment.

I'm interested in taking this bug.

@suchithjn225 Sure thing! Let us know how far you get with #41272 (comment). We're also on IRC.

@suchithjn225 I'll yield to you -- good luck!

Auto merge of #41316 - suchithjn225:issue-41272, r=eddyb

Rollup merge of rust-lang#136536 - DuskyElf:master, r=jieyouxu

Unrolled build for rust-lang#136536

Navigation Menu

Repository navigation

if clauses following an if let are compiled to match guards #41272

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

if clauses following an if let are compiled to match guards #41272

Description

Activity

eddyb commented on Apr 13, 2017

nikomatsakis commented on Apr 13, 2017

nikomatsakis commented on Apr 13, 2017

nikomatsakis commented on Apr 13, 2017

cuviper commented on Apr 14, 2017

eddyb commented on Apr 14, 2017

cuviper commented on Apr 14, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions