Repository navigation
Rust 1.17 regression - yamlette 0.0.2 #40964
Description
Activity
- addedregression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
on Mar 31, 2017 Hi guys, thank you very much for the report, love your work!
I have added some explicit lifetimes around. I'm not exactly sure it's related to #40319 however, now it appears that invocation ofself.do_the_musicborrowsvolumesfor the whole lifetime ofperformer_buffers(https://travis-ci.org/dnsl48/yamlette/jobs/217654253).
I would appreciate if you could confirm this assumption, which frankly seems to be correct behaviour to me now.
Feels like I've been using some fault technics to trick the borrow checker there. Probably I'll have to rewrite this place a bit. At the moment I'm doing lots of refactoring all over the library anyways, and I'm glad there's one more place to be rewritten in a more proper way.
Cheers@dnsl48 looking at those diffs, it's not obvious to me why those patches should be needed. I'll try to build your crate locally and investigate.
@dnsl48 trying to build the crate, I agree that the current error is correct. As you said,
do_the_music()borrowsvolumesfor the whole lifetime ofperformer_buffers, since data fromvolumesis put intoperformer_buffers.Reacted by Serge Latyntsev- addedT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.A-type-systemArea: Type systemArea: Type system
on Apr 4, 2017 This is #40319, which was not marked as relnotes. Marking as relnotes myself.
Closing, since the PR in question ins tagged as relnotes now. (Thanks @arielb1)
https://github.com/dnsl48/yamlette
cc @dnsl48