Skip to content

Tracking issue for the addition of the compile_error! macro #40872

Description

@sfackler

Activity

  1. added
    B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.
    T-libs-api[DEPRECATED; DO NOT USE]
    on Mar 28, 2017
  2. sfackler commented on Mar 28, 2017

    @sfackler
    MemberAuthor
  3. est31 commented on Apr 28, 2017

    @est31
    Member

    On IRC, @moonheart08 has expressed desire to implement this. I've helped a little bit, can continue mentoring.

  4. wesleywiser commented on May 25, 2017

    @wesleywiser
    Member

    @est31 do you know if @moonheart08 is still interested in working on this? If not, I'd love to work on it.

  5. est31 commented on May 25, 2017

    @est31
    Member

    I have heard about them wanting to submit their changes it about a week ago or so. Lets wait one week more.

  6. wesleywiser commented on May 25, 2017

    @wesleywiser
    Member

    Ok, sounds good.

  7. lu-zero commented on Jun 11, 2017

    @lu-zero
    Contributor

    I implemented it as compiler plugin a while ago, maybe I could try to see how hard would be to move it in the right place?

    https://github.com/lu-zero/compiler_error

  8. Geal commented on Jun 11, 2017

    @Geal
    Contributor

    FYI, there's a crate that does it as a compiler plugin, in the meantime: compiler_error
    (for people like me who come to this issue and need it right now)

  9. 1 remaining item

  10. sfackler commented on Jul 13, 2017

    @sfackler
    MemberAuthor

    The feature here is pretty straightforward, so let's stabilize it!

    @rfcbot fcp merge

  11. rfcbot commented on Jul 13, 2017

    @rfcbot

    Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

    No concerns currently listed.

    Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  12. added
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Jul 13, 2017
  13. rfcbot commented on Jul 20, 2017

    @rfcbot

    🔔 This is now entering its final comment period, as per the review above. 🔔

  14. added
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    and removed
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Jul 20, 2017
  15. added a commit that references this issue on Aug 12, 2017
    febb255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.T-libs-api[DEPRECATED; DO NOT USE]final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions