rustdoc sidebar styling doesn't extend to bottom of page if content is taller than sidebar

Introduced in #40265

@wesleywiser

Might be able to fix this using flexbox?

I actually don't hate this, but would be fine with it changing too.

On Sun, Mar 12, 2017 at 4:30 PM, Corey Farwell ***@***.***> wrote: Might be able to fix this using flexbox? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#40459 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABsiido4YObnrG0vYa9WGB8upaDcHFjks5rlFXtgaJpZM4Maqf4> .

I can't seem to repro this. What browser are you using?

Firefox 51.0.1

Hmm... I'm not seeing it on FF 52 on macOS

Since I didn't specify earlier, the page in the screenshot above is: https://doc.rust-lang.org/nightly/std/

In case there was any concern about version differences, I just upgraded to version 52.0 and can still reproduce the screenshot.

I can see it on that page. I was testing my local build which doesn't seem to be experiencing the issue.

For some reason, my local copy has

.sidebar {
    width: 100%;
}

instead of

.sidebar {
    width: 100vh;
}

I'm not sure why it's different but that fixes the issue.

Rollup merge of rust-lang#40497 - wesleywiser:fix_sidebar, r=Guillaum…

Navigation Menu