Repository navigation
1.15.1 (and earlier) armhf failing Items_and_attributes_15 doc test, passes on other architectures #40260
Description
8 months ago back in version 1.10.0 this test was called Items_and_attributes_14 and it hung rather than failed, here is a stacktrace.
We can ignore it with this patch:
--- rustc.git.orig/src/doc/reference.md
+++ rustc.git/src/doc/reference.md
@@ -1133,7 +1133,7 @@ bodies defined in Rust code _can be call
in the same way as any other Rust function, except that they have the `extern`
modifier.
-```
+```{.ignore}
// Declares an extern fn, the ABI defaults to "C"
extern fn new_i32() -> i32 { 0 }
Metadata
Metadata
Assignees
Labels
No labels
Activity
[-]1.15.1 armhf failing Items_and_attributes_15 doc test, passes on other architectures[/-][+]1.15.1 (and earlier) armhf failing Items_and_attributes_15 doc test, passes on other architectures[/+]Mark-Simulacrum commentedon May 26, 2017
@infinity0 I'm not sure what the bug is here. Is the test (now here) hanging, crashing, or failing today?
infinity0 commentedon Jun 15, 2017
Still failing today with 1.17.0 armv7, I tested on asachi.debian.org in a armv8l 32-bit chroot, with a clean upstream tarball (i.e. not the Debian package).
Due to #41291 I can't use rust's own 1.16 as stage0, I'm using Debian's 1.16 dynamically linked against LLVM, which recently has had the fix for #41291 backported into it. I don't think this would be affecting this issue, but in case it is, here is my ./configure line:
and to make the build work (i.e. to reach this point where it fails) I have to use these patches:
arielb1 commentedon Jun 15, 2017
The problematic test is:
"stdcall"only exists on x86. Looks like the test needs to be marked asrust,ignore, or as @kmcallister suggested, you can doarielb1 commentedon Jun 15, 2017
That is supposed to hide the test from the docs. I'll try to open a PR early next week if you won't open one before.
infinity0 commentedon Jun 16, 2017
The
#[cfg]guard could work yes, but this type of problem (ABI mismatch vs architecture) has come up before, e.g. #24958 and we haveignore-arm,ignore-aarch64insrc/test/debuginfo/type-names.rsstill marked asFIXME.Apparently there was some work done (#36421) to define which architectures support / don't support which ABIs and then this information could be used by the test runners to automatically ignore certain tests like this. I don't know what the progress is though, I only skimmed the ticket.
arielb1 commentedon Jun 16, 2017
Test runners are not supposed to automatically ignore tests. Maybe we should have a
require-stdcall-abiflag or whatever that you can put on the test that makes it ignored on all archs that do not support stdcall, but the test runner itself should not start parsing tests and ignoring them.infinity0 commentedon Jun 16, 2017
Then perhaps one could extend #36421 to support a
#[cfg(target_abi.contains("XXX"))]gate instead of hard-coding arch/ABI assumptions everywhere?arielb1 commentedon Jun 16, 2017
Local problems, local fixes (implementing more features in
cfgtakes an RFC and a stabilization cycle and...).infinity0 commentedon Jun 16, 2017
I understand. It would have wider applications though, outside of disabling tests in rustc. Suppose I want to write a
-syscrate that links against some non-rust library. Then I could use this, instead of having to hard-codetarget_archgates and having to maintain and update these for new architectures. Maybe something to consider for the future.arielb1 commentedon Jun 16, 2017
@infinity0
Such a change would definitely require an RFC (in https://github.com/rust-lang/rfcs). Feel free to write one, but it will take at least half a year or so to get implemented.
ignore doctest of `extern "stdcall"` on non-x86