Skip to content

Cargo on beta needs updating to build Rust on master #39504

Closed
Closed
Cargo on beta needs updating to build Rust on master#39504
Assignees
alexcrichton
Labels
P-highHigh priorityregression-from-stable-to-betaPerformance or correctness regression from stable to beta.
Milestone
1.16.0

Description

@alexcrichton
alexcrichton
opened on Feb 3, 2017

In #39463 I've opted due to not upgrade Cargo yet due to the errors preventing landing.

We need to track down what's causing this problem, land that change on Cargo master, then backport that change to rust-1.16.0 Cargo, and then update the Cargo used to bootstrap Rust on the master branch.

I'm tagging this as a regression as it's something we'll need to fix before the next release, and we shouldn't lose track of it!

Activity

  1. alexcrichton
    added
    regression-from-stable-to-betaPerformance or correctness regression from stable to beta.
    on Feb 3, 2017

  2. alexcrichton commented on Feb 3, 2017

    @alexcrichton
    alexcrichton
    on Feb 3, 2017
    MemberAuthor

    So here's what I'm thinking is happening

    • Cargo emits $folder\deps\libcompiler_builtins-$hash.rlib
    • Cargo hard-links that to $folder\libcompiler_builtins.rlib
    • Rustbuild hard-links the former to $sysroot/lib/.../libcompiler_builtins-$hash.rlib
    • Later on we run cargo test
    • As part of cargo test's normal execution, it attempts to re-hard-link the $hash file to the non-deps file (the first two steps above)
    • Presumably some concurrent invocation of rustc has the library open (to read it)

    This means that we're deleting a hard link where the actual file has a handle open to it elsewhere (opened through another link). Windows doesn't like this!

  3. brson
    added
    T-tools
    P-highHigh priority
    on Feb 9, 2017
  4. brson
    assigned
    alexcrichton
    on Feb 9, 2017
  5. brson
    modified the milestone: 1.16.0 on Feb 11, 2017
  6. alexcrichton
    added this to the 1.16.0 milestone on Feb 11, 2017
  7. alexcrichton
    added a commit that references this issue on Mar 6, 2017

    rustbuild: Use copies instead of hard links

    44bf3ec
  8. bors
    added a commit that references this issue on Mar 7, 2017

    Auto merge of #39518 - alexcrichton:update-cargo, r=brson

    d8bef59

  9. 10 remaining items

  10. alexcrichton
    added a commit that references this issue on Mar 10, 2017

    Rollup merge of rust-lang#39518 - alexcrichton:update-cargo, r=arielb1

    1c0daa5
  11. bors
    closed this as completedin #39518on Mar 10, 2017
  12. alexcrichton
    added a commit that references this issue on Sep 10, 2017

    rustbuild: Switch back to using hard links

    38bedfa
  13. bors
    added a commit that references this issue on Sep 10, 2017

    Auto merge of #44260 - alexcrichton:hardlink-no-copy, r=Mark-Simulacrum

    6d445e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P-highHigh priorityregression-from-stable-to-betaPerformance or correctness regression from stable to beta.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions