Skip to content

rustbuild: i686 rustc artifact is gone #38637

Closed
Closed
rustbuild: i686 rustc artifact is gone#38637
Labels
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Description

@xen0n
xen0n
opened on Dec 27, 2016

This is the reason of nightly packaging failing. I strongly suspect my own #38468 for that, although I don't yet know why the artifact is skipped in the first place. I'll investigate further.

Activity

  1. xen0n commented on Dec 27, 2016

    @xen0n
    xen0n
    on Dec 27, 2016
    ContributorAuthor

    Indeed:

    In step.rs we have some logic to presumably shave off some test time by checking if the rule is host-only, limiting the cross product to hosts array if applicable. However after #38468 the hosts array only consists of the build triple, so the output of host rules is effectively filtered to build-triple-only.

    My apologies. Patch pending.

  2. xen0n commented on Dec 27, 2016

    @xen0n
    xen0n
    on Dec 27, 2016
    ContributorAuthor

    Opened #38639.

    Before #38468: (some additional debug info added by me, not present in the PR)

    target rule dist-analysis: hosts=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
host rule dist-src: hosts=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
target rule dist-std: hosts=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
target rule dist-docs: hosts=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
target rule dist-mingw: hosts=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
host rule dist-rustc: hosts=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
bootstrap top targets:
        Step { name: "dist-analysis", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-analysis", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-analysis", stage: 2, host: "i686-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-analysis", stage: 2, host: "i686-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-src", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-src", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-src", stage: 2, host: "i686-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-src", stage: 2, host: "i686-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-std", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-std", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-std", stage: 2, host: "i686-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-std", stage: 2, host: "i686-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-docs", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-docs", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-docs", stage: 2, host: "i686-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-docs", stage: 2, host: "i686-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-mingw", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-mingw", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-mingw", stage: 2, host: "i686-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-mingw", stage: 2, host: "i686-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-rustc", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-rustc", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-rustc", stage: 2, host: "i686-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-rustc", stage: 2, host: "i686-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }

    After #38468, before #38639:

    host rule dist-rustc: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu"]
target rule dist-analysis: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
target rule dist-std: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
target rule dist-mingw: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
host rule dist-src: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu"]
target rule dist-docs: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
bootstrap top targets:
        Step { name: "dist-rustc", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-analysis", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-analysis", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-std", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-std", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-mingw", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-mingw", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-src", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-docs", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-docs", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }

    After:

    target rule dist-mingw: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
target rule dist-docs: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
host rule dist-rustc: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
host rule dist-src: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
target rule dist-analysis: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
target rule dist-std: hosts=["x86_64-unknown-linux-gnu"] arr=["x86_64-unknown-linux-gnu", "i686-unknown-linux-gnu"]
bootstrap top targets:
        Step { name: "dist-mingw", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-mingw", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-docs", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-docs", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-rustc", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-rustc", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-src", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-src", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-analysis", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-analysis", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
        Step { name: "dist-std", stage: 2, host: "x86_64-unknown-linux-gnu", target: "x86_64-unknown-linux-gnu" }
        Step { name: "dist-std", stage: 2, host: "x86_64-unknown-linux-gnu", target: "i686-unknown-linux-gnu" }
  3. sanxiyn
    added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    on Dec 28, 2016
  4. bors
    closed this as completedin cf89453on Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions