Skip to content

Naming convention for static mut is not enforced #37145

Closed
Closed
Naming convention for static mut is not enforced#37145
Labels
A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.

Description

@matklad
matklad
opened on Oct 13, 2016

The following program does not report any naming convention warnings:

#![allow(dead_code)]

static mut snake_case: u32 = 0;
static mut camelCase: u32 = 0;
static mut SCREAMING_SNAKE_CASE: u32 = 0;
static mut CapitalizedCamelCase: u32 = 0;

fn main() {}

Looks like only SCREAMING_SNAKE_CASE should be allowed? If I remove muts, I get the warnings. Or have we already deprecated static muts (pre rfc: https://internals.rust-lang.org/t/pre-rfc-remove-static-mut/1437/20) ?

Activity

  1. apasel422
    added
    A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.
    on Oct 13, 2016

  2. sfackler commented on Oct 14, 2016

    @sfackler
    sfackler
    on Oct 14, 2016
    Member

    Static muts are not deprecated. This looks like it's just an oversight in those lints. The convention should be identical to normal statics.

  3. matklad commented on Oct 14, 2016

    @matklad
    matklad
    on Oct 14, 2016
    ContributorAuthor

    Ok, I'll try to submit a PR then.

  4. bors
    added a commit that references this issue on Oct 17, 2016

    Auto merge of #37162 - matklad:static-mut-lint, r=jseyfried

    07b86d0
  5. bors
    closed this as completedin #37162on Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions