Repository navigation
Tracking issue for {IpAddr,SockAddr}::ip_v{4,6} methods #36949
Description
Activity
Can I propose stabilising these methods?
Sounds reasonable to me!
@rfcbot fcp merge
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:
No concerns currently listed.
Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
Yes -- the bot has been buggy lately. Thanks for catching it -- I'll mark it manually.
🔔 This issue is entering its final comment period for stabilization 🔔
Reacted by Abhishek Chanda🔔 This is now entering its final comment period, as per the review above. 🔔
psst @alexcrichton, I wasn't able to add the
final-comment-periodlabel, please do so.Sorry for bugging on this again, but shouldn't this be accepted now since it has been in FCP for more than a week?
@achanda this is for stabilizing, so we'll have a batch PR that rounds up everything and stabilizes close to the end of the cycle.
Reacted by Abhishek Chanda
These methods are proposed:
IpAddr::is_ipv4()SockAddr::is_ipv4()These return
trueif the underlying IP address is an IPv4 address.IpAddr::is_ipv6()SockAddr::is_ipv6()These return
trueif the underlying IP address is an IPv6 address.#36707
#36762