Logging of newtyped uints is broken #3506

Activity

1. nikomatsakis commented on Sep 15, 2012

   

   nikomatsakis

   on Sep 15, 2012

   ContributorAuthor

   More actions

   This is a real hindrance to debugging the type checker, so I put it as a blocker for 0.4.
2. Blei commented on Sep 16, 2012

   

   Blei

   on Sep 16, 2012

   Contributor

   More actions

   Even more interesting:

   enum Foo = uint;
   
   fn main() {
       let x = Foo(0);
       let y = Foo(1);
       io::println(fmt!("%?, %?", x, y));
   }
   

   Produces:

   Foo(8892280), 
   

   Where the printed value changes in each invocation...
3. Blei commented on Sep 16, 2012

   

   Blei

   on Sep 16, 2012

   Contributor

   More actions

   This issue can be fixed with

   diff --git a/src/libcore/repr.rs b/src/libcore/repr.rs
   index a0d6b01..610cc6f 100644
   --- a/src/libcore/repr.rs
   +++ b/src/libcore/repr.rs
   @@ -881,13 +881,13 @@ impl ReprPrinterWrapper : TyVisitor {
                let mut enum_state = stack.last();
                match enum_state.state {
                    PreVariant => {
   -                    let disr_ptr = self.printer.ptr as *int;
   -                    if *disr_ptr == disr_val {
   +                    //let disr_ptr = self.printer.ptr as *int;
   +                    //if *disr_ptr == disr_val {
                            enum_state.state = InVariant;
                            self.printer.writer.write_str(name);
   -                        self.printer.bump(sys::size_of::<int>());
   +                        //self.printer.bump(sys::size_of::<int>());
                            stack.set_elt(stack.len() - 1, enum_state);
   -                    }
   +                    //}
                    }
                    InVariant | PostVariant => {}
                }

   This is almost certainly not the correct fix, but might be a hint about where the problem is.
4. pcwalton

   closed this as completedin be162daon Sep 16, 2012
5. nikomatsakis commented on Sep 17, 2012

   

   nikomatsakis

   on Sep 17, 2012

   ContributorAuthor

   More actions

   Thanks, I hadn't gotten around to opening repr.rs, but after your
   comments the fix seems pretty obvious. Will push a patch soon.
6. nikomatsakis commented on Sep 17, 2012

   

   nikomatsakis

   on Sep 17, 2012

   ContributorAuthor

   More actions

   Oh, I should rebase before I repeat @pcwalton's work :)
7. bors

   added a commit that references this issue on May 15, 2021

   Merge pull request rust-lang#3506 from rchaser53/issue-3505

   ...

   d0df47f
8. RalfJung

   added a commit that references this issue on Apr 25, 2024

   Auto merge of rust-lang#3506 - rust-lang:rustup-2024-04-24, r=RalfJung

   ...

   a3fddf2
9. U007D

   added a commit that references this issue on Aug 21, 2026

   Merge pull request rust-lang#3506 from slyngbaek/3183

   ...

   34bc0f4