Skip to content

rustbuild: make clean doesn't clean enough #33986

Description

@alexcrichton

Errors like http://buildbot.rust-lang.org/builders/auto-linux-64-cross-netbsd/builds/462 are happening on the bots, e.g.:

   Compiling bootstrap v0.0.0 (file:///buildslave/rust-buildbot/slave/auto-linux-64-cross-netbsd/build/src/bootstrap)
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value: Utf8Error { valid_up_to: 0 }', ../src/libcore/result.rs:746
note: Run with `RUST_BACKTRACE=1` for a backtrace.

error: Could not compile `bootstrap`.

To learn more, run the command again with --verbose.

This is #33778 under the covers, but rustbuild's make clean command should blow away the build system directory ahead of time to be more resilient to bugs like this.

Activity

  1. added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    A-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)
    on May 31, 2016
  2. added a commit that references this issue on May 31, 2016
    ac19420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions