lint mode for int/uint in FFI does not warn about *uint, but should

Right now if you have an FFI function like:

fn foo(c: *uint, l: uint);

you only get a warning about the variable l, but c is (probably) equally broken. This actually but is in the LLVM bindings, where we translated unsigned * to *uint.

Additionally, this should actually be checking the types, not operating on the AST level.

This still only warns for the second parameter. A more complete test case:

fn main() {}

extern {
    fn foo(c: *uint, l: uint);
}

Still happens. Nominating production ready since FFI is a huge use case.

accepted for production-ready milestone

auto merge of #7734 : alexcrichton/rust/issue-3395, r=sanxiyn

Auto merge of rust-lang#3395 - rust-lang:rustup-2024-03-23, r=saethlin

Merge rust-lang#3395

Navigation Menu

Repository navigation

lint mode for int/uint in FFI does not warn about *uint, but should #3395

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

lint mode for int/uint in FFI does not warn about *uint, but should #3395

Description

Activity

pcwalton commented on Sep 6, 2012

bstrie commented on May 6, 2013

metajack commented on Jul 11, 2013

graydon commented on Jul 11, 2013

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions