Skip to content

Support per-stage RUSTFLAGS in rustbuild. #33609

Closed
#63722
Closed
Support per-stage RUSTFLAGS in rustbuild.#33609
#63722
Labels
C-feature-requestCategory: A feature request, i.e: not implemented / a PR.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Description

@eddyb
eddyb
opened on May 13, 2016

Right now rustbuild invokes cargo which wants to rebuild the world if it sees a different RUSTFLAGS value, while my workflow involves changing RUSTFLAGS just to test stage1+ with -Z orbit.

It would be nice to have passing --stage1-rustflags "-Z orbit" to the python script (or the environment variable `RUSTFLAGS1="-Z orbit") just work.

Currently the Makefiles have something similar but it doesn't actually work for compiletest, just rustc.

Activity

  1. eddyb
    assigned
    alexcrichton
    on May 13, 2016
  2. alexcrichton
    added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    on May 13, 2016

  3. apaprocki commented on Feb 23, 2017

    @apaprocki
    apaprocki
    on Feb 23, 2017

    Did rustbuild ever get support for this? This appears to also be breaking chroot builds that need to pass per-stage sysroot values.

  4. Mark-Simulacrum commented on May 24, 2017

    @Mark-Simulacrum
    Mark-Simulacrum
    on May 24, 2017
    Member

    I'm going to unassign @alexcrichton from this; I think others should be able to implement this and as far as I know they don't have any particular concern with this specific bug.

  5. Mark-Simulacrum
    added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    on Jul 25, 2017
  6. Mark-Simulacrum
    unassigned
    alexcrichton
    on Jul 25, 2017
  7. Mark-Simulacrum
    added
    C-feature-requestCategory: A feature request, i.e: not implemented / a PR.
    and removed
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    on Jul 25, 2017
  8. Mark-Simulacrum
    added
    WG-infra-rustbuild
    on Sep 15, 2017
  9. Mark-Simulacrum
    added this to the milestone on Sep 15, 2017
  10. aturon
    removed this from the milestone on Sep 15, 2017
  11. Mark-Simulacrum
    removed
    WG-infra-rustbuild
    on Apr 13, 2018

  12. Mark-Simulacrum commented on Aug 11, 2019

    @Mark-Simulacrum
    Mark-Simulacrum
    on Aug 11, 2019
    Member

    We support this via RUSTFLAG_STAGE_NOT_0 and RUSTFLAGS_STAGE_0 set in the environment today.

  13. Mark-Simulacrum
    closed this as completedon Aug 11, 2019

  14. eddyb commented on Aug 12, 2019

    @eddyb
    eddyb
    on Aug 12, 2019
    ContributorAuthor

    @Mark-Simulacrum I wonder if we should switch to RUSTFLAGS_BOOTSTRAP and RUSTFLAGS_NOT_BOOTSTRAP.

  15. Mark-Simulacrum commented on Aug 12, 2019

    @Mark-Simulacrum
    Mark-Simulacrum
    on Aug 12, 2019
    Member

    That would make sense, I'll reopen to track that.

  16. Mark-Simulacrum
    reopened this on Aug 12, 2019
  17. Centril
    added a commit that references this issue on Aug 20, 2019

    Rollup merge of rust-lang#63722 - Mark-Simulacrum:bootstrap-rustflags…

    af77aed
  18. bors
    closed this as completedin af77aedon Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-feature-requestCategory: A feature request, i.e: not implemented / a PR.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions