Skip to content

rustbuild: allow using ninja to build LLVM #32809

Description

@nagisa

Ninja is much faster at building LLVM, especially when more cores get involved. We should either:

  1. Autodetect presence of ninja and use it automatically (with an option to force use of make); or
  2. Allow using ninja (via some option).

Activity

  1. added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    on Apr 7, 2016
  2. alexcrichton commented on Apr 7, 2016

    @alexcrichton
    Member

    If anyone wants to dive into rustbuild, this should be a pretty easy bug to tackle! (in theory).

    You'd probably want to start out by adding a check to sanity.rs to just see if ninja exists and then when we later build LLVM you should just be able to pass the argument to CMake!

    We already just call cmake --build so I think that takes care of running ninja when it's configured, so we just need to tell CMake to use ninja.

  3. caipre commented on Apr 8, 2016

    @caipre
    Contributor

    I'll take this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions