Utilize if..let instead of single match branch

rust/src/librustc_trans/trans/type_of.rs

Lines 320 to 323 in 98a59cf

    
           match cx.lltypes().borrow().get(&t) { 
        
               Some(&llty) => return llty, 
        
               None => () 
        
           }

More info: https://doc.rust-lang.org/book/if-let.html

There are matches like this all over the place. I just replaced some of the ones in trans in a branch I'm working on atm.

Clippy's single_match lint should help finding them.

or maybe this would help

ag "match.+\n\s+Some.+\n\s+(None|_) => (\(\)|\{\})"

can I pick this up?

rust-lang#31820 - Utilize `if..let` instead of single `match` branch

@dileepbapat

@dileepbapat Go for it! Let us know if you need any help

@frewsxcv

@frewsxcv let me know if this is ok

@dileepbapat

@dileepbapat Looks good, nice job! Your changes are waiting in a queue to be merged:

http://buildbot.rust-lang.org/homu/queue/rust

Rollup merge of rust-lang#31842 - dileepbapat:master, r=alexcrichton

This can be closed now.

@dileepbapat

Thanks again @dileepbapat!

Rollup merge of #31842 - dileepbapat:master, r=alexcrichton

Navigation Menu

Repository navigation

Utilize `if..let` instead of single `match` branch #31820

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	match cx.lltypes().borrow().get(&t) {
	Some(&llty) => return llty,
	None => ()
	}

Utilize if..let instead of single match branch #31820

Description

Activity

eddyb commented on Feb 22, 2016

durka commented on Feb 22, 2016

nxnfufunezn commented on Feb 22, 2016

dileepbapat commented on Feb 23, 2016

frewsxcv commented on Feb 23, 2016

dileepbapat commented on Feb 24, 2016

frewsxcv commented on Feb 24, 2016

durka commented on Feb 25, 2016

frewsxcv commented on Feb 25, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Utilize `if..let` instead of single `match` branch #31820