Repository navigation
Add levenshtein distance based suggestions everywhere #30197
Description
Currently, we suggest typo fixes in case of function calls, locals, and field accesses. So, both the marked lines below will suggest the correct fix:
struct A {foo: u8}
fn main() {
let x = A {foo: 1};
x.fob; // here
let aaaaaaa=1;
let z = aaaaaab; // here
}However, this is not the case for imports, crates, and inline paths. We should fix this.
This is probably not an easy bug, but should be fun. Basically you need to look for the source of the "could not find X" error, and do something similar to
rust/src/librustc_resolve/lib.rs
Line 3625 in 99925fb
@apasel422 @Wafflespeanut want to work on this?
Activity
Manishearth commentedon Dec 8, 2015
Go ahead!
Auto merge of #30377 - Wafflespeanut:levenshtein, r=Manishearth
mitaa commentedon Feb 27, 2016
I was surprised that I didn't get a suggestion here
mitaa commentedon Feb 27, 2016
is_empty? (p and t are flipped)Manishearth commentedon Feb 27, 2016
No, we just don't handle methods.
cramertj commentedon May 25, 2016
Did crate and inline path support ever get added for this? If not, I'd be interested in giving it a shot.
Manishearth commentedon May 25, 2016
I don't think so. Go ahead!
nikhilshagri commentedon Jul 10, 2016
@Manishearth can I pick this up if nobody else is working on it?
Manishearth commentedon Jul 10, 2016
Sure!
20 remaining items
ConnorGray commentedon May 2, 2017
Okay, thanks for the clarification. And thanks anyway. I'm still wading through it, and I think I've made some progress understanding nonetheless.
laumann commentedon Aug 19, 2017
Hi! Is anyone working on adding suggestions for method names (re @mitaa's
is_emtpy()example)? I have a patch that I wrote some time ago that implements this, but if someone else is working on it I don't want to get in the way.laumann commentedon Sep 26, 2017
If @petrochenkov's list is being kept up-to-date, I think the "method calls" point can be crossed off.
petrochenkov commentedon Sep 26, 2017
@laumann
Updated the list.
Thanks for working on this.
laumann commentedon Sep 26, 2017
@petrochenkov Happy to help :-)
I considered looking into suggestions for "Lifetime and label names" next - that sounds like it should be more or less straight-forward...
petrochenkov commentedon Oct 3, 2017
@laumann
It should be straightforward, but note that with #44524 typos in lifetimes will be impossible by definition (every typo becomes a new lifetime, modulo some corner cases).
Rollup merge of rust-lang#45173 - laumann:suggest-misspelled-labels, …
steveklabnik commentedon Dec 25, 2018
Triage: do we plan on doing more of this? I'm not sure.