Skip to content

Blanket trait impls are not listed as implementations in rustdoc #29503

Description

@bluss

ToString has the implementation impl<T: fmt::Display + ?Sized> ToString for T which is not listed in its documentation page.

It is however listed in libstd, so rustdoc does the correct thing after doc inlining.

This bug with blanket impls shows up in user's crates, see discussion on users.rust-lang; for example the Itertools trait in itertools does not have its blanket impl visible in the docs.

Activity

  1. added
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    on Nov 1, 2015
  2. pmarcelll commented on Mar 29, 2016

    @pmarcelll
    Contributor

    It regressed on nightly, it also disappeard from the libstd page.

  3. jethrogb commented on Apr 15, 2016

    @jethrogb
    Contributor

    The regression is not due to specialization, see e.g. https://doc.rust-lang.org/stable/std/any/trait.Any.html vs https://doc.rust-lang.org/nightly/std/any/trait.Any.html which does not use specialization. Regression is also visible on beta btw.

  4. flying-sheep commented on May 6, 2016

    @flying-sheep
    Contributor

    hmm, is this bug affecting me? my docs, corresponding src

  5. bluss commented on May 6, 2016

    @bluss
    ContributorAuthor

    @flying-sheep Yes, it's the same bug.

  6. flying-sheep commented on May 7, 2016

    @flying-sheep
    Contributor

    thanks. a bit confusing, since that impl is the whole point of my crate 😄

  7. added a commit that references this issue on May 9, 2016
    6100b70
  8. added 3 commits that reference this issue on May 9, 2016
    812dae4
    6913b9f
    433f907
  9. jethrogb commented on May 10, 2016

    @jethrogb
    Contributor

    The regression was already fixed in #33133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions