Repository navigation
API Docs: option #29366
Description
Activity
In the
as_mutanditer_mutexamples, a match is used with aNone => {}arm.if letwould be more idiomatic.In the documentation for
unwrap_or(and maybe for related methods likeok_orandor), it would be nice to make a note that the arguments to a function are always fully evaluated, meaning thatfn foo(opt: Option<Bar>) -> Bar { let bar = opt.unwrap_or(return Bar::new()); bar.baz() }will always return
Bar::new()instead ofopt.unwrap().baz(), even if opt isSome(_). This seems like a pitfall otherwise.I am happy to mentor anyone who wants to tackle this issue.
@steveklabnik I'd like to help on this.
@irfanhudda awesome! Let me know if I can help you help us in any way :)
@steveklabnik Module level docs look fine here. I think the documentation of
IntoIter,IterandIterMutstructs can be improved. Do we also need examples or anything else?Oh, I just noticed I didn't add a checklist for this issue!
They do not need examples, but they should follow the standard iterator boilerplate: https://doc.rust-lang.org/stable/std/iter/struct.SkipWhile.html
An iterator that rejects elements while predicate is true.
This struct is created by the skip_while() method on Iterator. See its documentation for more.
Reacted by Irfan Hudda- added 9 commits that reference this issue
on Apr 3, 2017 :D
Part of #29329
http://doc.rust-lang.org/std/option/