Validate usage of inline attributes

syntax::attr::find_inline_attr has a FIXME saying "validate the usage of #[inline] and #[inline(always)]".

I don't believe this is backwards incompatible, renominating.

Also I don't know what this means.

I can't tell where the comment originally came from, but I'm assuming it means checking that #[inline] doesn't get used to annotate something that can't be inlined (because it's not a function).

just a bug, removing milestone/nomination.

Consensus is that this means a lint pass detecting #[inline] being applied
to bad code.

Visiting for triage, nontrivial amount of work so leaving as properly classified for now.

Amusingly, today this says

    // FIXME (#2809)---validate the usage of #[inline] and #[inline]

No more always, but it's still there.

#22490 validates well-formedness of the inline attribute, but it is still unknown whether there’s any ways to misuse #[inline] attribute in a way which would be invalid (e.g. not on a function).

If the comment in original report happens to have referred to validation of attribute well-formedness, this issue can then be closed. Do not forget to remove the FIXME comment too.

Auto merge of rust-lang#2809 - saethlin:round_ties_even, r=oli-obk

Support for inductively verifying contracts of recursive functions (r…

Merge pull request rust-lang#2809 from khyperia/fix-2776

Merge rust-lang#2809

Navigation Menu

Repository navigation

Validate usage of inline attributes #2809

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Validate usage of inline attributes #2809

Description

Activity

pcwalton commented on May 16, 2013

pcwalton commented on May 16, 2013

catamorphism commented on May 16, 2013

graydon commented on Jun 6, 2013

nikomatsakis commented on Jun 6, 2013

graydon commented on Aug 15, 2013

steveklabnik commented on Aug 12, 2014

nagisa commented on Feb 19, 2015

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions