Bad span for self type #27522

Activity

1. marcusklaas commented on Aug 4, 2015

   

   marcusklaas

   on Aug 4, 2015

   ContributorAuthor

   More actions

   It's seems to be caused by this `hack': https://github.com/rust-lang/rust/blob/master/src/libsyntax/ast.rs#L1503-L1521. (Called here: https://github.com/rust-lang/rust/blob/master/src/libsyntax/parse/parser.rs#L4321-L4323)

   Weirdly enough, the proper span is shown for diagnostics: play.rust-lang.org

   Any pointers, @eddyb?
2. steveklabnik

   added

   A-trait-systemArea: Trait systemArea: Trait system

   A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lints

   on Aug 4, 2015
3. eddyb commented on Aug 5, 2015

   

   eddyb

   on Aug 5, 2015

   Contributor

   More actions

   Since Self works in impls now, it's probably time to retire that hack and always provide the correct type.
   SelfExplicit appears to hold the type (with its correct span), instead of the self argument itself, in this case.
4. estebank commented on Aug 23, 2016

   

   estebank

   on Aug 23, 2016

   Contributor

   More actions

   This has been fixed. Can this ticket be closed?
5. eddyb

   added

   E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.Call for participation: An issue has been fixed and does not reproduce, but no test has been added.

   on Aug 23, 2016
6. estebank

   added a commit that references this issue on Dec 25, 2016

   Add test for correct span for type

   ...

   3caf478
7. GuillaumeGomez

   added a commit that references this issue on Jan 4, 2017

   Rollup merge of rust-lang#38606 - estebank:test-for-27522, r=petroche…

   ...

   This issue will close once commit 74c6fcc is merged into the 'main' branch.

   74c6fcc
8. estebank

   added a commit that references this issue on Jan 4, 2017

   Add test for correct span for type

   ...

   1a4a6b9
9. sanxiyn

   added a commit that references this issue on Jan 10, 2017

   Rollup merge of rust-lang#38606 - estebank:test-for-27522, r=petroche…

   ...

   This issue will close once commit a81cd32 is merged into the 'master' branch.

   a81cd32
10. bors

    closed this as completedin #38606on Jan 10, 2017