Allow linking to specific impls in rustdoc #23552

Activity

1. huonw

   added

   T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.

   on Mar 20, 2015
2. huonw

   changed the title [-]Allow linking to specific impls rustdoc[/-] [+]Allow linking to specific impls in rustdoc[/+] on Mar 20, 2015
3. steveklabnik commented on Jun 6, 2016

   

   steveklabnik

   on Jun 6, 2016

   Contributor

   More actions

   Triage: no change here
4. steveklabnik

   added

   T-tools

   and removed

   T-tools

   on Mar 9, 2017
5. steveklabnik

   added

   T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

   and removed

   T-tools

   on May 18, 2017
6. mcarton commented on Jun 28, 2017

   

   mcarton

   on Jun 28, 2017

   Contributor

   More actions

   👍 This would be quite useful, I just wanted to point out to a friend why String + &str is possible, but there is no way to point to this particular implementation. This is especially annoying since this implementation is rather well documented.
7. Mark-Simulacrum

   added

   C-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.

   on Jul 22, 2017
8. QuietMisdreavus

   added

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

   on Aug 15, 2017
9. QuietMisdreavus

   self-assigned this

   on Aug 15, 2017
10. QuietMisdreavus commented on Aug 15, 2017

    

    QuietMisdreavus

    on Aug 15, 2017

    Contributor

    More actions

    This should be a fairly small change, so i'm opening it up to new contributors. in src/librustdoc/html/render.rs, there's a function called render_impl that has some code at the top that prints the impl line. The change to fix this would be to add a spot in between where it prints i.inner_impl() and the next print to add an anchor link that points to the h3 right there. There's a function available called derive_id that you can hand a potential id to that will make sure you get a unique anchor for your link. Actually inserting the anchor can be done like in #43747 so you get a nice section marker that pops up on hover.

    If you'd like to work on this and want help, let me know! I'm "misdreavus" on IRC. I'd love to get you acclimated to working on rustdoc.
11. Jouan

    added a commit that references this issue on Aug 18, 2017

    Add links for impls

    ...

    c8d58a3
12. frewsxcv

    added a commit that references this issue on Aug 26, 2017

    Rollup merge of rust-lang#43979 - Jouan:Add-links-for-impls, r=Guilla…

    ...

    b4dcdee
13. QuietMisdreavus commented on Aug 27, 2017

    

    QuietMisdreavus

    on Aug 27, 2017

    Contributor

    More actions

    Since #43979 got merged, i'll close out this issue.
14. QuietMisdreavus

    closed this as completedon Aug 27, 2017
15. lnicola

    added a commit that references this issue on Oct 26, 2026

    Merge pull request rust-lang#23552 from ChayimFriedman2/fix-status-msg

    ...

    be4c857