Skip to content

Fix or remove FIXME in std::smallintmap #2347

Closed

Description

@catamorphism

A FIXME in std::smallintmap says: "FIXME: Should not be @; there's a bug somewhere in rustc that requires this to be" (as in: the definition of the smallintmap type is @{mut v: [mut option<T>]} and should be {mut v: [mut option<T>]}). I tried fixing this (and changing insert to take its first argument by pointer), but maybe there's still a bug in rustc, as the fix causes map lookups to fail. So it seems more complicated.

Activity

  1. msullivan commented on May 29, 2012

    @msullivan
    Contributor

    Presumably it is getting passed by value somewhere or another and so it gets copied? What /should/ the behavior of copying a smallintmap be?

  2. catamorphism commented on Feb 1, 2013

    @catamorphism
    ContributorAuthor

    Obsolete.

  3. added a commit that references this issue on Apr 19, 2025
  4. added a commit that references this issue on Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions